Refactoring template processing #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hairyhenderson
force-pushed
the
refactor-template-processing
branch
2 times, most recently
from
04d98a2
to
97ca55e
Compare
hairyhenderson
force-pushed
the
refactor-template-processing
branch
4 times, most recently
from
c38e48c
to
8c7c61d
Compare
Signed-off-by: Dave Henderson <dhenderson@gmail.com>
hairyhenderson
force-pushed
the
refactor-template-processing
branch
from
8c7c61d
to
8436344
Compare
Signed-off-by: Dave Henderson <dhenderson@gmail.com>
hairyhenderson
force-pushed
the
refactor-template-processing
branch
from
8436344
to
6aec329
Compare
hairyhenderson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the flow a bit, as it separates the preparation phase (gathering & reading templates and figuring out where they need to go) from the rendering phase.
This should make it simpler to introduce some parallel speedups when processing large input dirs later on.
Signed-off-by: Dave Henderson dhenderson@gmail.com