Remove VFS argument from ReadSource which isn't used #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! This looks good. However, this changes public API, so I'm going to hold on to this until other major API changes need to be made (which I think will be necessary for your Vault PRs in motion right now). |
hairyhenderson
approved these changes
Aug 1, 2017
stuart-c
force-pushed
the
remove-vfs-arg
branch
7 times, most recently
from
3e8805d
to
d0f2b6f
Compare
stuart-c
force-pushed
the
remove-vfs-arg
branch
from
d0f2b6f
to
a6c1eaf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReadSource is passed a VFS argument (set from source.FS) as the first argument, but this is never used. Instead source is passed so the readFile proc uses that instead (and directly accesses source.FS)