Namespacing the aws funcs #148
Conversation
|
The problem with this approach, as it stands right now, is that the function has to be exported to be visible, so it changes to |
aws/aws.go
Outdated
|
|
||
| // NS - | ||
| func NS() *awsFuncs { | ||
| if af == nil { |
There was a problem hiding this comment.
thanks, this seemed inelegant, but I didn't want to use init() - I'll replace with sync.Once 🙂
aws/aws.go
Outdated
| type awsFuncs struct{} | ||
|
|
||
| func (a *awsFuncs) EC2Region(def ...string) string { | ||
| if meta == nil { |
hairyhenderson
force-pushed
the
aws-namespace
branch
3 times, most recently
from
877836c
to
9ce9d1e
Compare
|
I've been doing some digging around the upper/lower-case function name problem, and I found some discussion of how they did it in hugo - gohugoio/hugo#3042 It looks like basically the same approach was tried initially but in the end they seem to have gone with something more complex. I'm still wrapping my head around what exactly was done - most of the magic seems to be in https://github.com/spf13/hugo/tree/master/tpl |
hairyhenderson
force-pushed
the
aws-namespace
branch
from
9ce9d1e
to
3d14852
Compare
|
Ok, seems I totally misunderstood what's going on in hugo - they don't seem to support lower-cased function names in namespaces. What I was looking at was aliases, which are in the global namespace. We're stuck with upper-cased function names. NBD. I'll move on with life now 😛 |
hairyhenderson
force-pushed
the
aws-namespace
branch
2 times, most recently
from
3a356d2
to
9556e07
Compare
hairyhenderson
changed the title
hairyhenderson
force-pushed
the
aws-namespace
branch
3 times, most recently
from
e2ad280
to
8c6440d
Compare
Signed-off-by: Dave Henderson <dhenderson@gmail.com>
Signed-off-by: Dave Henderson <dhenderson@gmail.com>
hairyhenderson
force-pushed
the
aws-namespace
branch
from
8c6440d
to
d8f2a93
Compare
|
@hairyhenderson Are you good with this approach now? |
|
@sean- yeah, it seems to be fine. There's probably further refinements that could be made to the specifics, but as a general approach I'm happy with it for now. |
This is an offshoot of #145 to try and figure out the best way to namespace built-in functions.
Ideally, I'd like to be able to use the existing function names, and simply move them under a namespace. So, instead of
{{ ec2region }}, I'd like{{ aws.ec2region }}.Signed-off-by: Dave Henderson dhenderson@gmail.com