Performance fixes for running ec2tag in non-aws environments #111
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #110
This does two things:
InstanceDescriber
in casedescriber
is called multiple times, and caches it earlier so that thee.metaClient.nonAws
bool can be set earlier, avoiding unnecessary calls.http.Client
with a 500ms timeoutOn my mac, this reduces the amount of time it takes to timeout a
ec2tag
function from 900ms to 500ms.And in Linux, it's down from 21s to 500ms.
Signed-off-by: Dave Henderson dhenderson@gmail.com