[ci] Use numSplits instead of copy pasting test steps #11787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danking
previously requested changes
Apr 20, 2022
| outputs: | ||
| - from: /io/test-output | ||
| to: /test-output-4 | ||
| to: /test-output |
There was a problem hiding this comment.
Hmm this seems incorrect. All the test outputs will race to overwrite one another. I don’t think we care about the outputs though. Just remove them? Or add a template variable to outputs?
There was a problem hiding this comment.
I added a prefix in #11771 such that if a job uses splits, its outputs get stowed under the job name to avoid clobbering. So for the first split this output would actually be /test_hail_java_0/test-output. Happy to remove too if we never use them
There was a problem hiding this comment.
It's not exactly explicit so happy to hear alternatives
There was a problem hiding this comment.
Ah. Hmm. A bit confusing. I don't have a better alternative though.
danking
approved these changes
Apr 21, 2022
CDiaz96
pushed a commit
to CDiaz96/hail
that referenced
this pull request
Apr 27, 2022
* [ci] Use numSplits instead of copy pasting test steps * change pytest env vars to use run image split vars * delete more remnants * fix job name for split run image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diff is horrendous but I just deleted the copy-pasted steps 1-n and changed the zero'th to be the new step.
Also fixed a bug in the brand new vectorized RunImage where the job name wasn't getting the index suffix.