[httpx] use timeouts and remove footgun #11770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`httpx.ClientSession` did not include the logic to set up the timeout. I do not recall why I had a factory function distinct from the class itself. That was a mistake. I leave the factory function because it is used prevasively. However, now, allocating the class itself is also OK.
daniel-goldstein
previously requested changes
Apr 15, 2022
hail/python/hailtop/httpx.py
Outdated
| tls = external_client_ssl_context() | ||
|
|
||
| assert 'connector' not in kwargs | ||
| kwargs['connector'] = aiohttp.TCPConnector(ssl=tls) |
There was a problem hiding this comment.
Nit: a little awkward here putting connector back in kwargs but not timeout. Can we leave kwargs as it is and pass connector explicitly to ClientSession?
daniel-goldstein
approved these changes
Apr 19, 2022
added 2 commits
April 20, 2022 12:11
CDiaz96
pushed a commit
to CDiaz96/hail
that referenced
this pull request
Apr 27, 2022
* [httpx] use timeouts and remove footgun `httpx.ClientSession` did not include the logic to set up the timeout. I do not recall why I had a factory function distinct from the class itself. That was a mistake. I leave the factory function because it is used prevasively. However, now, allocating the class itself is also OK. * Update httpx.py * fix type * syntax error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
httpx.ClientSessiondid not include the logic to set up the timeout. I donot recall why I had a factory function distinct from the class itself. That
was a mistake. I leave the factory function because it is used prevasively.
However, now, allocating the class itself is also OK.