forked from AliceO2Group/O2Physics
-
Notifications
You must be signed in to change notification settings - Fork 0
Please consider the following formatting changes to #2386 #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AliceO2Group#2461) Co-authored-by: Nima Zardoshti <nzardosh@alicecerno2.cern.ch>
Co-authored-by: Nima Zardoshti <nzardosh@alicecerno2.cern.ch>
…oup#2481) * Update jet tables * Adapt tasks to updated jet tables * Update jet matching * Fix formatting * Refactor jet tables * Cleanup * Fix formatting * Remove obsolete jet matching * Update * Fix formatting * Update * Simplify preslicing * Fix using declarations and header * Fix formatting * Homogenise jet names * PWGJE: adding QA task for HF jet finder * debugging jet finder * adding tutorial task for jets --------- Co-authored-by: Jochen Klein <jochen.klein@cern.ch> Co-authored-by: Nima Zardoshti <nzardosh@alicecerno2.cern.ch>
6e6ccc0 to
914949a
Compare
f5e0ef8 to
b7752a1
Compare
|
This PR has not been updated in the last 30 days. Is it still needed? Unless further action is taken, it will be closed in 5 days. |
hahassan7
pushed a commit
that referenced
this pull request
Oct 21, 2023
) * Implement efficiency computation macro for D2H * Add new line at the end of config file * Fix bug in TH2 projection, add safety for asymmetric error setting when converting TEfficiency to TH1, and add pt binning option * Add missing loop on all pt bins after rebinning * Remove scaling after rebinning (not nedded), re-organise helper methods, try solving MegaLinter errors * Add safety for canvas file extension and try to solve mypy errors * New attempt to solve mypy errors * Try to fix type of save_canvas() last argument + import-error on modules * Add copyright + attempt to solve mypy error * Attempt to solve pyright error #1 * Second attempt to solve pyright error * Apply linters automatic fixes * Apply Vit's comments * Remove empty line between ROOT and style_formatter imports * Fix typo found by Fabio --------- Co-authored-by: Alexandre Bigot <abigot@sbgat402.in2p3.fr>
hahassan7
pushed a commit
that referenced
this pull request
Nov 7, 2023
AliceO2Group#3658) * preliminary support for Monte Carlo analysis + support for PROCESS_SWITCH + switch to templates in few function to trim down code bloat * fix for formatter #1 * implementing Victor comments * fix for formatter #2
hahassan7
pushed a commit
that referenced
this pull request
Nov 7, 2023
* templating the rest * reply to Victor comments * fix for formatter #1 * removed commented code
hahassan7
pushed a commit
that referenced
this pull request
Apr 4, 2024
AliceO2Group#4691) * support for analysis over converted Run 1 and Run 2 data + support for differential q-vectors * MegaLinter #1 * MegaLinter 2 * MegaLinter 3 * MegaLinter ´4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cannot be merged as is. You should either run
clang-formatyourself and update the pull request, or merge this PR in yours.You can find the AliceO2 coding conventions at https://github.com/AliceO2Group/CodingGuidelines.