Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vectorised RooLandau #1

Closed
wants to merge 26 commits into from
Closed

Vectorised RooLandau #1

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
ba1a4fe
[RF] Change evaluatePartition interface for test statistics.
hageboeck Feb 5, 2019
0edc1cb
[RF] Initial cleanups before touching RooVectorDataStore.
hageboeck Feb 5, 2019
9aa6af2
Remove dead code in RooGaussian.
hageboeck Feb 6, 2019
7c3e29d
Fix some typos in docs.
hageboeck Feb 7, 2019
0fecdee
WIP before sed-ing RooFit::DataBatch to RooSpan.
hageboeck Feb 8, 2019
4897f28
Make pointees of span backport writable.
hageboeck Feb 15, 2019
3cd7efd
[RF] Add a RooSpan to enable batched function evaluations.
hageboeck Feb 15, 2019
4d6803a
Add vdt math function to vectorised Gaussian prototype.
hageboeck Feb 18, 2019
4852d12
Further cleanups.
hageboeck Feb 22, 2019
6f5946a
Change batch evaluation interface.
hageboeck Mar 7, 2019
f0e2732
Vectorise exponential, extend its analytical integral.
hageboeck Apr 4, 2019
07c0a77
Make Gaussian integral not return zero, but 1E-300 if it vanishes.
hageboeck Apr 4, 2019
9667252
Clean up RooAddition, RooConstraintSum of member iterators.
hageboeck Apr 4, 2019
2cedee6
Disable cout in ProdPdf, make RooUnitTest failures more informative.
hageboeck Apr 4, 2019
28ba4dd
Add `BatchMode` switch for fitTo to switch on BatchMode.
hageboeck Apr 4, 2019
8b44331
Hacky batch&vector version for RooAddPdf.
hageboeck Apr 8, 2019
39abfc0
Add Pdf-local batch storage.
hageboeck Apr 23, 2019
2183424
[Mathmore] Vectorise Kahan summation algorithm.
hageboeck May 2, 2019
4c4c36f
Fix computation errors in batch-local storage strategy.
hageboeck May 20, 2019
a6583a7
[RF] Add generic evaluateBatch to RooAbsReal.
hageboeck Jul 3, 2019
a1b489f
[RF] Change batch evaluation interface to begin+size indexing.
hageboeck Jul 8, 2019
581a13d
[RF] Vectorise error checking in RooAbsPdf.
hageboeck Jul 11, 2019
3a3c906
[RF] Prevent empty names for RooAbsArgs.
hageboeck Jul 11, 2019
2be0476
[RF] Vectorised Landau PDF
Jul 26, 2019
f2abe2d
[RF]
Jul 26, 2019
a2b8483
[RF] Merged header file into pdf source file
Jul 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix some typos in docs.
  • Loading branch information
@hageboeck
hageboeck committed Jul 9, 2019
commit 7c3e29d20edbb0203a29fcbdbbdeb22a6182b494
12 changes: 6 additions & 6 deletions roofit/roofitcore/src/RooAbsPdf.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -651,12 +651,12 @@ Double_t RooAbsPdf::getLogVal(const RooArgSet* nset) const


////////////////////////////////////////////////////////////////////////////////
/// Returned the extended likelihood term (Nexpect - Nobserved*log(NExpected)
/// of this PDF for the given number of observed events
/// Return the extended likelihood term (\f$ N_\mathrm{expect} - N_\mathrm{observed} \cdot \log(N_\mathrm{expect} \f$)
/// of this PDF for the given number of observed events.
///
/// For successfull operation the PDF implementation must indicate
/// it is extendable by overloading canBeExtended() and must
/// implemented the expectedEvents() function.
/// For successful operation, the PDF implementation must indicate that
/// it is extendable by overloading `canBeExtended()`, and must
/// implement the `expectedEvents()` function.

Double_t RooAbsPdf::extendedTerm(Double_t observed, const RooArgSet* nset) const
{
Expand Down Expand Up @@ -3022,7 +3022,7 @@ RooAbsReal* RooAbsPdf::createCdf(const RooArgSet& iset, const RooArgSet& nset)


////////////////////////////////////////////////////////////////////////////////
/// Create an object that represents the integral of the function over one or more observables listed in iset
/// Create an object that represents the integral of the function over one or more observables listed in `iset`.
/// The actual integration calculation is only performed when the return object is evaluated. The name
/// of the integral object is automatically constructed from the name of the input function, the variables
/// it integrates and the range integrates over
Expand Down
4 changes: 2 additions & 2 deletions roofit/roofitcore/src/RooAbsReal.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3982,9 +3982,9 @@ RooAbsReal* RooAbsReal::createScanRI(const RooArgSet& iset, const RooArgSet& nse


////////////////////////////////////////////////////////////////////////////////
/// Utility function for createRunningIntegral that construct an
/// Utility function for createRunningIntegral. It creates an
/// object implementing the standard (analytical) integration
/// technique for calculating the running integral
/// technique for calculating the running integral.

RooAbsReal* RooAbsReal::createIntRI(const RooArgSet& iset, const RooArgSet& nset)
{
Expand Down