Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure Assembly-CSharp is not a target of CodeGen #168

Merged
merged 1 commit into from
Mar 28, 2021

Conversation

hadashiA
Copy link
Owner

Currently, any assembly that references VContainer.EnableCodeGen is a target of CodeGen optimization.

I noticed that Assembly-CSharp is targeted by default.
Since this is unnecessary and may lead to unintended behavior, we will disable CodeGen by default.

@vercel
Copy link

vercel bot commented Mar 28, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hadashia/vcontainer/BuQeAFe5p4YiErYEqe9fafNdZxma
✅ Preview: https://vcontainer-git-ku-without-codegen-assembly-csharp-hadashia.vercel.app

@hadashiA
Copy link
Owner Author

#167

@hadashiA hadashiA merged commit 62d32c7 into master Mar 28, 2021
@hadashiA hadashiA deleted the ku/without-codegen-assembly-csharp branch March 28, 2021 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant