-
-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UniTask integration #100
Merged
Merged
UniTask integration #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/hadashia/vcontainer/houuf30ot |
hadashiA
force-pushed
the
ku/unitask-integration
branch
from
January 29, 2021 18:48
11da734
to
0788f9f
Compare
hadashiA
force-pushed
the
ku/unitask-integration
branch
from
January 29, 2021 19:01
0788f9f
to
16c5428
Compare
hadashiA
force-pushed
the
ku/unitask-integration
branch
from
January 30, 2021 15:09
8d50568
to
95560bc
Compare
hadashiA
force-pushed
the
ku/unitask-integration
branch
from
January 31, 2021 07:57
a75c85b
to
83c1f8e
Compare
hadashiA
force-pushed
the
ku/unitask-integration
branch
from
January 31, 2021 08:06
83c1f8e
to
ce83554
Compare
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
hadashiA
force-pushed
the
ku/unitask-integration
branch
from
January 31, 2021 08:20
febdb22
to
6dc4e2e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
Unit Test Results0 files 0 suites 0s ⏱️ Results for commit 6dc4e2e. |
hadashiA
force-pushed
the
ku/unitask-integration
branch
from
January 31, 2021 08:38
6dc4e2e
to
a1477e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add IAsyncStartable
Why is there only one interface ?
UniTask can switch the execution of the async method at any time.
So I don't think we need a lot of interfaces to choose the timing.
e.g.
Is there a way to handle the error?
On the application side, we cannot write try / catch outside of Start()
Usually, we use default unobserved exception behaviour.
Or, we can use:
I added the following to do this for each LifetimeScope .
Also use:
How to use CancellationToken ?
TODO