Skip to content

Commit

Permalink
fix(primer-service): update OpenAPI golden test output
Browse files Browse the repository at this point in the history 
The previous commit bumped the `openapi3` package to version `3.2.4`,
which contains this pull request:

biocad/openapi3#88

The title of that PR is simply, "Give title to sub-schemas of oneOf
for sum types", and that is what has happened here to our golden test
output. Unhelpfully, there's no justification for why this change was
made, but it looks harmless enough. (This will presumably require a
corresponding schema change on the client side, though.)

We also bump the PVP for `openapi3` to reflect the new minimum version
requirement.

Signed-off-by: Drew Hess <src@drewhess.com>
  • Loading branch information
@dhess
dhess committed Feb 6, 2024
1 parent 941ee24 commit 32975be
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 1 deletion.
2 changes: 1 addition & 1 deletion primer-service/primer-service.cabal
View file
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ library
, insert-ordered-containers ^>=0.2.5.1
, logging-effect ^>=1.4
, mtl >=2.2.2 && <2.4.0
, openapi3 >=3.2 && <3.3.0
, openapi3 ^>=3.2.4
, optics >=0.4 && <0.5.0
, primer ^>=0.7.2
, primer-api ^>=0.7.2
Expand Down
19 changes: 19 additions & 0 deletions primer-service/test/outputs/OpenAPI/openapi.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
"tag",
"contents"
],
"title": "NoInput",
"type": "object"
},
{
Expand All @@ -37,6 +38,7 @@
"tag",
"contents"
],
"title": "Input",
"type": "object"
}
]
Expand Down Expand Up @@ -154,6 +156,7 @@
"tag",
"contents"
],
"title": "EvalFullRespTimedOut",
"type": "object"
},
{
Expand All @@ -172,6 +175,7 @@
"tag",
"contents"
],
"title": "EvalFullRespNormal",
"type": "object"
}
]
Expand Down Expand Up @@ -365,6 +369,7 @@
"tag",
"contents"
],
"title": "TextBody",
"type": "object"
},
{
Expand All @@ -383,6 +388,7 @@
"tag",
"contents"
],
"title": "PrimBody",
"type": "object"
},
{
Expand All @@ -401,6 +407,7 @@
"tag",
"contents"
],
"title": "BoxBody",
"type": "object"
},
{
Expand All @@ -419,6 +426,7 @@
"tag",
"contents"
],
"title": "NoBody",
"type": "object"
}
]
Expand Down Expand Up @@ -518,6 +526,7 @@
"tag",
"contents"
],
"title": "Ok",
"type": "object"
},
{
Expand All @@ -540,6 +549,7 @@
"got",
"tag"
],
"title": "Mismatch",
"type": "object"
}
]
Expand Down Expand Up @@ -676,6 +686,7 @@
"tag",
"contents"
],
"title": "PrimChar",
"type": "object"
},
{
Expand All @@ -694,6 +705,7 @@
"tag",
"contents"
],
"title": "PrimInt",
"type": "object"
},
{
Expand All @@ -712,6 +724,7 @@
"tag",
"contents"
],
"title": "PrimAnimation",
"type": "object"
}
]
Expand Down Expand Up @@ -819,6 +832,7 @@
"tag",
"contents"
],
"title": "SelectionDef",
"type": "object"
},
{
Expand All @@ -837,6 +851,7 @@
"tag",
"contents"
],
"title": "SelectionTypeDef",
"type": "object"
}
]
Expand Down Expand Up @@ -970,6 +985,7 @@
"tag",
"contents"
],
"title": "TypeDefParamNodeSelection",
"type": "object"
},
{
Expand All @@ -988,6 +1004,7 @@
"tag",
"contents"
],
"title": "TypeDefConsNodeSelection",
"type": "object"
}
]
Expand Down Expand Up @@ -1040,6 +1057,7 @@
"tag",
"contents"
],
"title": "Type",
"type": "object"
},
{
Expand All @@ -1058,6 +1076,7 @@
"tag",
"contents"
],
"title": "Kind",
"type": "object"
}
]
Expand Down

0 comments on commit 32975be

Please sign in to comment.