Skip to content

Conversation

@Casassarnau
Copy link

@Casassarnau Casassarnau commented Oct 3, 2019

What this PR does / Why we need it

A few sentences describing the overall goals of the pull request's commits.

Which issue(s) this PR fixes (optional)

Fixes #

Special notes for your reviewer (optional)

Some questions

  • I have read the contributing guidelines
  • I abide by this repository Code of Conduct
  • I understand that my PR won't be merged until Travis gives a "green light"

Additional Notes (optional)

Do you want to add anything else? We ❤️ to hear your opinions!

@casassg casassg temporarily deployed to hackupc-registration-bet-pr-76 October 3, 2019 09:09 Inactive
@casassg casassg temporarily deployed to hackupc-registration-bet-pr-76 October 4, 2019 14:40 Inactive
@casassg casassg temporarily deployed to hackupc-registration-bet-pr-76 October 4, 2019 17:09 Inactive
@casassg
Copy link
Member

casassg commented Oct 4, 2019

./baggage/views.py:25:1: E302 expected 2 blank lines, found 1
./baggage/views.py:61:21: W291 trailing whitespace
./baggage/views.py:71:32: E127 continuation line over-indented for visual indent
./baggage/views.py:74:17: W291 trailing whitespace
./baggage/views.py:88:25: E127 continuation line over-indented for visual indent
./baggage/views.py:255:1: E302 expected 2 blank lines, found 1
./baggage/views.py:257:34: E251 unexpected spaces around keyword / parameter equals
./baggage/views.py:257:36: E251 unexpected spaces around keyword / parameter equals
./baggage/views.py:266:121: E501 line too long (160 > 120 characters)
./baggage/views.py:273:121: E501 line too long (200 > 120 characters)
./baggage/views.py:273:173: E231 missing whitespace after ':'
./baggage/views.py:273:190: E231 missing whitespace after ':'
./baggage/views.py:275:1: W293 blank line contains whitespace
./baggage/views.py:291:1: W293 blank line contains whitespace
./baggage/views.py:292:1: W293 blank line contains whitespace
./baggage/views.py:293:1: W293 blank line contains whitespace
./baggage/views.py:294:1: W293 blank line contains whitespace
./baggage/views.py:295:1: W391 blank line at end of file
./baggage/views.py:295:1: W293 blank line contains whitespace
./baggage/views.py:295:1: E303 too many blank lines (4)
./judging/views.py:110:121: E501 line too long (126 > 120 characters)
./checkin/views.py:23:1: E302 expected 2 blank lines, found 1
./checkin/views.py:40:25: E127 continuation line over-indented for visual indent
./checkin/views.py:110:14: E111 indentation is not a multiple of four
./checkin/views.py:111:40: E127 continuation line over-indented for visual indent
./checkin/views.py:117:1: E302 expected 2 blank lines, found 1
./checkin/views.py:131:34: E251 unexpected spaces around keyword / parameter equals
./checkin/views.py:131:36: E251 unexpected spaces around keyword / parameter equals
./checkin/views.py:134:44: W291 trailing whitespace
./checkin/views.py:140:1: W293 blank line contains whitespace
./checkin/views.py:143:24: E222 multiple spaces after operator
./checkin/views.py:148:1: W293 blank line contains whitespace
./checkin/views.py:149:1: W391 blank line at end of file
./checkin/views.py:149:1: W293 blank line contains whitespace
./applications/models.py:73:1: E303 too many blank lines (3)
./app/emails.py:3:1: F401 'django.template.Context' imported but unused

@casassg casassg temporarily deployed to hackupc-registration-bet-pr-76 October 4, 2019 21:43 Inactive
@casassg casassg temporarily deployed to hackupc-registration-bet-pr-76 October 4, 2019 21:48 Inactive
@casassg casassg temporarily deployed to hackupc-registration-bet-pr-76 October 4, 2019 22:06 Inactive
@casassg casassg temporarily deployed to hackupc-registration-bet-pr-76 October 4, 2019 22:17 Inactive
@casassg casassg temporarily deployed to hackupc-registration-bet-pr-76 October 4, 2019 22:21 Inactive
@casassg casassg temporarily deployed to hackupc-registration-bet-pr-76 October 4, 2019 22:32 Inactive
Copy link
Author

@Casassarnau Casassarnau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now Baggage and Check-in have their own APIs

@ghost ghost merged commit eee3cfc into master Oct 4, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants