Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the --mouth-mask argument to the CLI #851

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mehdico
Copy link

@mehdico mehdico commented Dec 24, 2024

Added the --mouth-mask argument to the CLI for enabling the mouth mask feature.

Summary by Sourcery

New Features:

  • Added a --mouth-mask option to the command-line interface to control the mouth masking functionality.

Copy link
Contributor

sourcery-ai bot commented Dec 24, 2024

Reviewer's Guide by Sourcery

This pull request introduces a new command-line argument, --mouth-mask, which enables the mouth masking feature. The argument is a boolean flag that defaults to False. When set to True, the mouth masking feature is activated.

Class diagram showing the updated CLI argument structure

classDiagram
    class ArgumentParser {
        +add_argument()
    }
    class GlobalConfig {
        +bool keep_audio
        +bool keep_frames
        +bool many_faces
        +bool mouth_mask
        +bool nsfw_filter
        +bool map_faces
        +string video_encoder
        +parse_args()
    }
    note for GlobalConfig "Added mouth_mask boolean flag"
    ArgumentParser -- GlobalConfig: configures >
Loading

File-Level Changes

Change Details Files
Added the --mouth-mask argument to the CLI
  • Added the --mouth-mask argument to the parse_args function.
  • Set the default value of the mouth_mask argument to False.
  • Added the mouth_mask argument to the global variables.
modules/core.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mehdico - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The help text for --mouth-mask should be more descriptive to explain what the mouth mask feature does and its default state
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant