Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added batch file to run all the steps using just one command #83

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

Thepathakarpit
Copy link
Contributor

@Thepathakarpit Thepathakarpit commented Aug 9, 2024

  1. Clone the directory
  2. cd Deep-Live-Cam
  3. setup_deep_live_cam.bat

And it does everything you mentioned as steps no need to follow through everything. Will make users more comfortable and your product usable. All requirements setup packages it does everything.

Summary by Sourcery

Add a batch file to automate the setup and execution of the Deep-Live-Cam project, including dependency checks, repository cloning, model downloading, and GPU acceleration options.

New Features:

  • Introduce a batch file to automate the setup and execution of the Deep-Live-Cam project.

Enhancements:

  • Add checks and installations for required dependencies such as Python, Pip, Git, FFMPEG, and Visual Studio 2022 Runtimes.
  • Automate the cloning of the repository and downloading of necessary models.
  • Provide options for GPU acceleration setup, including CUDA, CoreML, DirectML, and OpenVINO.

Copy link
Contributor

sourcery-ai bot commented Aug 9, 2024

Reviewer's Guide by Sourcery

This pull request adds a new batch script, 'setup_deep_live_cam.bat', which automates the entire setup process for the Deep-Live-Cam project. The script checks for necessary software, installs missing dependencies, clones the repository, downloads required models, sets up a Python virtual environment, installs Python packages, and provides options for GPU acceleration. This enhancement simplifies the setup process, making it more user-friendly and efficient.

File-Level Changes

Files Changes
setup_deep_live_cam.bat Introduced a comprehensive batch script to automate the setup and execution of the Deep-Live-Cam project, including environment setup, dependency installation, and GPU acceleration options.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Thepathakarpit - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding more robust error handling, especially for critical steps like model downloads and repository cloning.
  • Provide fallback options or instructions for systems without winget, to ensure broader compatibility across different Windows environments.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

setup_deep_live_cam.bat Show resolved Hide resolved
@hacksider hacksider merged commit f48b1b4 into hacksider:main Aug 9, 2024
devin-ai-integration bot pushed a commit to Sniffr/Deep-Live-Cam that referenced this pull request Jan 15, 2025
Added batch file to run all the steps using just one command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants