Add index at revision table for improving system performance 🚀 #1856
Merged
Yukaii merged 2 commits intohackmdio:developfrom Jun 5, 2024
Merged
Add index at revision table for improving system performance 🚀 #1856Yukaii merged 2 commits intohackmdio:developfrom
Yukaii merged 2 commits intohackmdio:developfrom
Conversation
yamashush
force-pushed
the
add-index-at-revisions
branch
from
a6249ab to
8f7827d
Compare
Signed-off-by: yamashush <38120991+yamashush@users.noreply.github.com>
Yukaii
force-pushed
the
add-index-at-revisions
branch
from
8f7827d to
0701fd7
Compare
Signed-off-by: Yukai Huang <yukaihuangtw@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SQLs to select records from the revision table is a sequential scan.
These SQLs use note id as a search key, but there is no index on the note id column.
I want to change to index scan to improve system performance 🚀
The records in the revision table will become huge during operation, so sequential scans should be avoided.
This is especially because the following fetch processing is called frequently.
codimd/app.js
Line 277 in d157fde
For your reference, the organization I belong to has already changed it. (kufu#19)