Fix #1369 - make manage_users work again #1370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soerface
force-pushed
the
patch-1
branch
3 times, most recently
from
543fcdf to
873ab7e
Compare
|
Thanks for contribution @soerface |
jackycute
reviewed
Dec 5, 2019
jackycute
reviewed
Dec 5, 2019
|
Hi @soerface thanks for your contribution! I've also added |
|
Hi @soerface, |
|
Hey @jackycute, all commits are signed now. Or would you like me to squash them all into a single commit? |
It would be nice if you can squash the last two commits, thank you. |
Use another return code for "User already exist" This allows external scripts differentiating between "failure" and "everything is fine" Co-Authored-By: Max Wu <jackymaxj@gmail.com> Signed-off-by: Soeren Wegener <wegener92@gmail.com>
|
Thanks @soerface |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1369
The manage_users script currently does not work in the official docker image, since it compares to undefined. However, the returned variable is null, resulting in crashing of the script. (see #1369)
Additionally, I changed a return code in the
createUser()function. This allows other scripts to distinguish between the failure reasons.