Skip to content

Fixed minio image upload InvalidBucketNameError error #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

abola
Copy link

@abola abola commented Dec 24, 2021

Add new attribute codimd.imageUpload.minio.bucket link to secret environment CMD_S3_BUCKET

Before this fix, must define bucket name in s3 attributes and with one fake accessKeyId like below.

codimd:
  (....)
  imageUpload:
    storeType: minio
    minio:
      endpoint: minio-host
      secure: false
      port: 9000
      accessKey: abcd1234
      secretKey: abcd1234
    s3:
      accessKeyId: fake_id_here
      bucket: codimd

This PR add bucket to minio attributes to fix this prob

codimd:
  (....)
  imageUpload:
    storeType: minio
    minio:
      endpoint: minio_host
      secure: false
      port: 9000
      accessKey: abcd1234
      secretKey: abcd1234
      bucket: codimd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant