Skip to content

dev to main - switch csv to tsv to avoid user input errors #1025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tektaxi merged 13 commits into from
Dec 7, 2024
Merged

dev to main - switch csv to tsv to avoid user input errors #1025

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
ef0b5ca
Remove Netlify link from README
MikaVohl Oct 30, 2024
a7df54b
Removed Facebook eventPrompt; Fixed typo in application submission; A…
joshuazhou744 Nov 1, 2024
e954b11
Fix/fixed phone number input (#1006)
joshuazhou744 Nov 1, 2024
4bef38d
MLH Form Changes (#1016)
tektaxi Nov 15, 2024
bbd4712
Add 3rd checkbox to Terms and Conditions (#1012)
JamieXiao Nov 15, 2024
c902184
Clear the fields and add success message after sending account invite…
JamieXiao Nov 15, 2024
6c8c332
Fix/update grad years (#1015)
JamieXiao Nov 15, 2024
95d15c6
Accomodate intl phone numbers in account creation
Nov 16, 2024
b5752f5
Changed conditional rendering for editing phone number in ManageAccou…
Nov 16, 2024
b57db94
Updated hacker export by removing/commenting out fields that don't ex…
allennatang Nov 27, 2024
f97022a
Merge branch 'main' into develop - fix conflicts
tektaxi Dec 7, 2024
aab83ea
switch csv export to tsv to avoid input errors
tektaxi Dec 7, 2024
5211e94
Merge branch 'main' into develop
tektaxi Dec 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/features/Search/Search.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ class SearchContainer extends React.Component<{}, ISearchState> {
headers.forEach((header) => {
tempHeaders.push(header.label);
});
const csvData: string[] = [tempHeaders.join(',')];
const csvData: string[] = [tempHeaders.join('\t')]; // actually in tsv format
this.filter().forEach((result) => {
if (result.selected) {
const row: string[] = [];
Expand All @@ -294,10 +294,10 @@ class SearchContainer extends React.Component<{}, ISearchState> {
}
row.push(value);
});
csvData.push(row.join(','));
csvData.push(row.join('\t'));
}
});
fileDownload(csvData.join('\n'), 'hackerData.csv', 'text/csv');
fileDownload(csvData.join('\n'), 'hackerData.tsv', 'text/tsv');
}

private async triggerSearch(): Promise<void> {
Expand Down