Added country of residence field to Personal Details section of hacker application#1013
Closed
allennatang wants to merge 4 commits intomainfrom
Closed
Added country of residence field to Personal Details section of hacker application#1013allennatang wants to merge 4 commits intomainfrom
allennatang wants to merge 4 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Author
|
I fixed some issues and tested it, it works. Created a select menu with all the country options and Canada at the top.
|
10 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tickets:
#1009
List of changes:
I added country to all the files, see details in the issue linked above. Validation still needs to be added to hackerAPI.
Type of change:
How to test:
Fill out a hacker application and check that the country field is in Personal Details and works properly. Check that it went through to mongoDB.