Updated 'degree' options for application form to match MLH requirements#1011
Closed
allennatang wants to merge 5 commits intomainfrom
Closed
Updated 'degree' options for application form to match MLH requirements#1011allennatang wants to merge 5 commits intomainfrom
allennatang wants to merge 5 commits intomainfrom
Conversation
…dded phone number field to account creation. (#1005) Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca>
* Removed Facebook eventPrompt; Fixed typo in application submission; Added phone number field to account creation. * Initialize phone number as inputted value in sign up form so it doesn't default to 11111111111 --------- Co-authored-by: Joshua Zhou <j.zhou11@share.epsb.ca>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
PS C:\Users\allen\mcHacks\dashboard> git commit -m "Updated level of study options to match MLH requirements" [feat/change_level_of_study 0394c3e] Updated level of study options to match MLH requirements 1 file changed, 11 insertions(+), 4 deletions(-) PS C:\Users\allen\mcHacks\dashboard> git push origin feat/change_level_of_study To https://github.com/hackmcgill/dashboard.git ! [rejected] feat/change_level_of_study -> feat/change_level_of_study (non-fast-forward) error: failed to push some refs to 'https://github.com/hackmcgill/dashboard.git' hint: Updates were rejected because the tip of your current branch is behind hint: its remote counterpart. If you want to integrate the remote changes, hint: use 'git pull' before pushing again. hint: See the 'Note about fast-forwards' in 'git push --help' for details. PS C:\Users\allen\mcHacks\dashboard> git pull There is no tracking information for the current branch. Please specify which branch you want to merge with. See git-pull(1) for details. git pull <remote> <branch> If you wish to set tracking information for this branch you can do so with: git branch --set-upstream-to=origin/<branch> feat/change_level_of_study PS C:\Users\allen\mcHacks\dashboard> Merge branch 'feat/change_level_of_study' of https://github.com/hackmcgill/dashboard into feat/change_level_of_study
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List of changes:
In
degree.ts, updated options to match MLH requirements.Type of change:
How to test:
I had trouble logging in to my local server to test what the changes look like. I tried signing in with multiple different accounts but it didn't work, with no error message or "authentication failed" message. Please test what the new dropdown looks like.