Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tickets:
#1003
Also changed the hackerAPI hackmcgill/hackerAPI#936
List of changes:
In the hacker account form, changed the birthdate field to age field. Validated that it is between 0 and 100. Allowed users to edit their age field after account creation.
Type of change:
How did you do this?
More details in the linked issue.
How to test:
Questions:
Do I need to list changes in change log??? omg.
Why are my changes from changing export from .tsv to .csv here, I created a new branch?
Screenshots: