-
-
Notifications
You must be signed in to change notification settings - Fork 844
Updated Links Variable for Github #8435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh-pages
Are you sure you want to change the base?
Updated Links Variable for Github #8435
Conversation
The devops repo is being renamed from https://github.com/hackforla/ops to https://github.com/hackforla/devops with this change users will be able to navigate to the renamed repo from the hfla website's communities of practice page: https://www.hackforla.org/communities-of-practice
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Review ETA: 6pm 11/23/2025 |
|
Review ETA: 9:30 AM 11/23 |
izzy-me
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @abinetabate1! Great work on this PR.
Done Correctly:
- Merge branches correctly set
- Issue is correctly linked
- PR title is properly named
- code changes are correct and appropriate
- correctly assigned yourself and the status of the project
- action items have been checked off
Requested Changes:
- make sure to include a before and after screenshot of the website itself, not the inspected code for the website. If this isn't possible for whatever reason, please make note of it in the comments. I believe if you hover your mouse over the "View Github" button under DevOps on the communities of practice page, you should be able to see the change in your Docker environment.
Overall, great work! Thanks for taking up this issue
@izzy-me - hovering mouse over "View Github" does not show the change I made. I have added a note as per your suggestion. |
ldaws003
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @abinetabate1. Good work on this PR. The branches
Done Correctly:
- Branch was correctly named
- Issue is linked
- PR merge branch is correct
- PR title is appropriate
- code changes are exactly as requested
- correctly assigned yourself and the status of the project
- action items have been checked off
- PR is mostly correct
Requested Changes:
- Please remove the images of the code in the before and after screenshots. For any changes that cannot be shown in the UI, it is best to not include any screenshots and to put an explanation of why your code changes wouldn't result in a change in the website's looks.
Overall, great work! Thanks for taking up this issue
@ldaws003 - your requested change is not necessary. Issue asks to include screenshot. Plus I do not necessarily agree with your statement “For any changes….” Please approve or we can escalate to lead. |
|
@abinetabate1 thanks for working on this issue, all looks good! Since it requires Bonnie to merge this PR, I went ahead and closed the original issue so you can move on to working on your next issue without waiting. |
When this PR is ready to be merged. This has to be done at the Monday 5pm Pacific meeting between Dev/PM. Please link the PR in that agenda issue under new items
opsrepo name todevopsand then merge the PR.Fixes #8389
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
note: hovering over button does not show link url in chrome or edge browser. Including screenshot of chrome dev tools view of page to show the change that was made.
Visuals after changes are applied