Skip to content

updated project profile- added rachel #8162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from

Conversation

sarahgraup
Copy link
Member

Fixes #8000

What changes did you make?

  • inserted new profile after the last product manager and removed previous profile

Why did you make the changes (we will use this info to test)?

  • changed according to action items

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied Screenshot 2025-05-27 at 12 53 46 PM
Visuals after changes are applied Screenshot 2025-05-27 at 12 58 52 PM

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b sarahgraup-update-project-profile-8000 gh-pages
git pull https://github.com/sarahgraup/website.git update-project-profile-8000

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels May 27, 2025
@daras-cu daras-cu requested review from ryanfkeller and hoanhua14 May 28, 2025 02:09
Copy link
Member

@hoanhua14 hoanhua14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sarahgraup , thank you for working on this issue. Your code changes look good but there are a few changes needed:
Things you did well:

  • PR is done with the correct branch
  • Website page looks good on different viewports
  • Changes appear to address the issue action items

Things to change:

  • There's a merge conflict to be resolved
  • For the second question (Why did you make the changes ?), it's usually the reason for the edit, such as: to keep the page updated.
  • CodeQL section is not checked
  • Last checkbox in the action item list is not checked

I'm also curious about the code change which I'm hoping you can help to clarify. There were 7 lines removed and 7 lines added but I don't see removal mentioned in the action items.
I'll approve once changes are made. Thank you!

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs being reviewed in P: HfLA Website: Project Board May 28, 2025
@katiejnete katiejnete self-requested a review May 28, 2025 05:13
@katiejnete
Copy link
Member

Availability: Varying weekdays, 7-9pm
ETA: EOD

Copy link
Member

@katiejnete katiejnete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sarahgraup , thank you for taking on this issue.

Things you did well:

  • PR is done with the correct branch.
  • PR contains correctly formatted linked issue.
  • Website is still user-friendly and links and components still work as intended.

Suggested changes:

  • Please check for CodeQL Alerts and check the corresponding checkbox.
  • It looks like the 'before' and 'after' screenshots were accidentally switched. The image labeled 'before' is actually the 'after,' and vice versa. Please switch the screenshots.
  • I noticed that the old project profile lines were deleted and the updated ones were added above Sydney Walcoff’s project profile. As per the action items, the updated project profile lines should be added after the last Product Manager, following Rick Peng’s project profile instead.
  • Please change “Why did you make the changes (we will use this info to test)?” section to something like “To keep Expunge Assist project profiles up-to-date.”
  • Please resolve the merge conflict.

After making these changes, re-request a review from me. Thank you for your hard work!

@ryanfkeller
Copy link
Member

Review Availability: Weekdays 12-5p
ETA: TBD (likely +1 day to when other changes are addressed)

Thanks for taking this issue @sarahgraup!

I've taken a look through your PR already and largely agree with @hoanhua14 and @katiejnete (except to me the before and after screenshots look to be accurately ordered based on the code changes). I did see that there was a previously completed issue (#7702) that also tackled adding Rachel Ichniowski to this page, so I think you took the correct approach of updating their info rather than just adding them in again as a duplicate team member.

I don't have additional changes to request other than what your other reviewers have suggested, so I'll hold off on marking this as "needs changes" so I don't become another blocker on things they already caught! When you make your update, I'll take another look.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
Status: PRs being reviewed
Development

Successfully merging this pull request may close these issues.

Update Project Profile: Expunge Assist- Add Rachel Ichniowski
4 participants