-
-
Notifications
You must be signed in to change notification settings - Fork 830
updated project profile- added rachel #8162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh-pages
Are you sure you want to change the base?
updated project profile- added rachel #8162
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sarahgraup , thank you for working on this issue. Your code changes look good but there are a few changes needed:
Things you did well:
- PR is done with the correct branch
- Website page looks good on different viewports
- Changes appear to address the issue action items
Things to change:
- There's a merge conflict to be resolved
- For the second question (Why did you make the changes ?), it's usually the reason for the edit, such as: to keep the page updated.
- CodeQL section is not checked
- Last checkbox in the action item list is not checked
I'm also curious about the code change which I'm hoping you can help to clarify. There were 7 lines removed and 7 lines added but I don't see removal mentioned in the action items.
I'll approve once changes are made. Thank you!
Availability: Varying weekdays, 7-9pm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sarahgraup , thank you for taking on this issue.
Things you did well:
- PR is done with the correct branch.
- PR contains correctly formatted linked issue.
- Website is still user-friendly and links and components still work as intended.
Suggested changes:
- Please check for CodeQL Alerts and check the corresponding checkbox.
- It looks like the 'before' and 'after' screenshots were accidentally switched. The image labeled 'before' is actually the 'after,' and vice versa. Please switch the screenshots.
- I noticed that the old project profile lines were deleted and the updated ones were added above
Sydney Walcoff
’s project profile. As per the action items, the updated project profile lines should be added after the last Product Manager, followingRick Peng
’s project profile instead. - Please change “Why did you make the changes (we will use this info to test)?” section to something like “To keep Expunge Assist project profiles up-to-date.”
- Please resolve the merge conflict.
After making these changes, re-request a review from me. Thank you for your hard work!
Review Availability: Weekdays 12-5p Thanks for taking this issue @sarahgraup! I've taken a look through your PR already and largely agree with @hoanhua14 and @katiejnete (except to me the before and after screenshots look to be accurately ordered based on the code changes). I did see that there was a previously completed issue (#7702) that also tackled adding Rachel Ichniowski to this page, so I think you took the correct approach of updating their info rather than just adding them in again as a duplicate team member. I don't have additional changes to request other than what your other reviewers have suggested, so I'll hold off on marking this as "needs changes" so I don't become another blocker on things they already caught! When you make your update, I'll take another look. Thanks again! |
Fixes #8000
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied