-
-
Notifications
You must be signed in to change notification settings - Fork 776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Project Profile: Remove Gayle Martin from HackforLA.org Website #7720
base: gh-pages
Are you sure you want to change the base?
Update Project Profile: Remove Gayle Martin from HackforLA.org Website #7720
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@katiejnete great job on this issue.
- The branch name is correct with the issue number
- The before and after screenshots are good as well.
- Title and description is very clear and concise
Things you need to fix
- You need to fix the merge conflict
Thank you for taking on this issue.
…: remove Gayle and Nayan
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @katiejnete, Thanks for taking on this issue!
Things you did well:
- branch name contains issue #
- PR title and description sections are descriptive and succinct.
- Visual Changes are included
- Great job resolving the merge conflict!!!!
No changes needed, great job! Keep it up!
Fixes #6981
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied