Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Project Profile: Remove Gayle Martin from HackforLA.org Website #7720

Open
wants to merge 2 commits into
base: gh-pages
Choose a base branch
from

Conversation

katiejnete
Copy link
Member

Fixes #6981

What changes did you make?

  • Removed Gayle Martin lines from leadership variable in website markdown file (_projects/website.md)

Why did you make the changes (we will use this info to test)?

  • To keep list of current HfLA project team members on the website up-to-date

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied before
Visuals after changes are applied after

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b katiejnete-update-project-profile-remove-gayle-6981 gh-pages
git pull https://github.com/katiejnete/website.git update-project-profile-remove-gayle-6981

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Nov 15, 2024
@codyyjxn codyyjxn self-requested a review November 15, 2024 03:08
Copy link
Member

@codyyjxn codyyjxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@katiejnete great job on this issue.

  • The branch name is correct with the issue number
  • The before and after screenshots are good as well.
  • Title and description is very clear and concise

Things you need to fix

  • You need to fix the merge conflict

Thank you for taking on this issue.

Copy link
Member

@FamousHero FamousHero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @katiejnete, Thanks for taking on this issue!

Things you did well:

  • branch name contains issue #
  • PR title and description sections are descriptive and succinct.
  • Visual Changes are included
  • Great job resolving the merge conflict!!!!

No changes needed, great job! Keep it up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
Status: PRs being reviewed
Development

Successfully merging this pull request may close these issues.

Update Project Profile: remove Gayle Martin from HackforLA.org Website
3 participants