Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Heejung Hong to the LA TDM Calculator Leadership Page #7711

Merged
merged 2 commits into from
Nov 10, 2024

Conversation

mchait18
Copy link
Member

@mchait18 mchait18 commented Nov 8, 2024

Fixes #7646

What changes did you make?

  • I added Heejung Hong to the leadership page for LA TDM Calculator.

Why did you make the changes (we will use this info to test)?

To keep the leadership for LA TDM Calculator on the website up-to-date

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

![image]before 7646

Visuals after changes are applied

![image]after 7646

Copy link

github-actions bot commented Nov 8, 2024

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b mchait18-Add-Heejung-Hong-7646 gh-pages
git pull https://github.com/mchait18/website.git Add-Heejung-Hong-7646

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Nov 8, 2024
@floydferrer floydferrer self-requested a review November 8, 2024 23:32
@floydferrer
Copy link
Member

Review ETA: 11/8/2024 Friday
Availability: 12-5 PM Weekdays (PST)

Copy link
Member

@floydferrer floydferrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this issue, @mchait18 !

  • PR is done with the correct branch
  • The linked issue is included and accurate
  • Changes are correct
  • Slack and Github links direct to the correct destinations
  • Before-and-after screenshots are clear of the requested changes

Thanks for your contribution!

@TheManTheMythTheGameDev
Copy link
Member

Review ETA: 2 PM 11/9/24
Availability: Weekends

Copy link
Member

@TheManTheMythTheGameDev TheManTheMythTheGameDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Branches are correct
  • Issue is linked correctly
  • Changes look good on the website
  • Changes are simple and clean
    Great job! This PR looks perfect. Thank you for your work!

@t-will-gillis t-will-gillis merged commit 45db16e into hackforla:gh-pages Nov 10, 2024
3 checks passed
@t-will-gillis
Copy link
Member

Hi @mchait18 Great job on your issue. Quick note: for the checkbox under "CodeQL Alerts" above, you can either check the box after all changes have been saved, or you can add an 'X' to the raw markdown- it will display correctly as long as you remove any spaces.

It looks like you added the 'X', so just remember to remove the extra space and only show "- [x]" not "-[x ]" For example:

  • [x ] button with the extra space
  • button with only the 'x'

@mchait18
Copy link
Member Author

6 - PULL REQUESTS update

What is the number of your first merged pull request?

Did you receive any reviews that required you to change anything on your PR?

  • no
  • yes (if yes, describe what you learned)

Comments:
I learned how to check a checkbox in raw markup, by putting an x without any whitespace.
return to section 6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
Development

Successfully merging this pull request may close these issues.

Update Project Profile: LA TDM Calculator Add Heejung Hong
4 participants