-
-
Notifications
You must be signed in to change notification settings - Fork 776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Heejung Hong to the LA TDM Calculator Leadership Page #7711
Added Heejung Hong to the LA TDM Calculator Leadership Page #7711
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Review ETA: 11/8/2024 Friday |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this issue, @mchait18 !
- PR is done with the correct branch
- The linked issue is included and accurate
- Changes are correct
- Slack and Github links direct to the correct destinations
- Before-and-after screenshots are clear of the requested changes
Thanks for your contribution!
Review ETA: 2 PM 11/9/24 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Branches are correct
- Issue is linked correctly
- Changes look good on the website
- Changes are simple and clean
Great job! This PR looks perfect. Thank you for your work!
Hi @mchait18 Great job on your issue. Quick note: for the checkbox under "CodeQL Alerts" above, you can either check the box after all changes have been saved, or you can add an 'X' to the raw markdown- it will display correctly as long as you remove any spaces. It looks like you added the 'X', so just remember to remove the extra space and only show "- [x]" not "-[x ]" For example:
|
6 - PULL REQUESTS update
Comments: |
Fixes #7646
What changes did you make?
Why did you make the changes (we will use this info to test)?
To keep the leadership for LA TDM Calculator on the website up-to-date
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
![image]
Visuals after changes are applied
![image]