Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PR template with CodeQL instructions #7616

Merged
merged 5 commits into from
Oct 29, 2024
Merged

Update PR template with CodeQL instructions #7616

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a076fd5
Updated PR template code to add instructions regarding CodeQL scannin…
santisecco Sep 28, 2024
737d93c
Merge branch 'hackforla:gh-pages' into update-pr-template-codeql-5196
santisecco Sep 30, 2024
be09a42
Merge branch 'hackforla:gh-pages' into update-pr-template-codeql-5196
santisecco Oct 21, 2024
405471a
Update pull_request_template.md
santisecco Oct 21, 2024
72b6d1b
Update pull_request_template.md
santisecco Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,32 @@ Fixes #replace_this_text_with_the_issue_number
-
-

<h3>CodeQL Alerts</h3>


After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.


<details><summary>Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown</summary>

![Screenshot 2024-10-15 153738](https://github.com/user-attachments/assets/90b6ef81-bff7-410a-a961-7bea51f4a4d0)

</details>

If your issue has a CodeQL alert and is complexity: medium or higher, please let us know that you have checked and resolved. Please do not dismiss alerts.
t-will-gillis marked this conversation as resolved.
Show resolved Hide resolved
- [ ] I have checked this PR for CodeQL alerts. If CodeQL alerts were found:
t-will-gillis marked this conversation as resolved.
Show resolved Hide resolved
- [ ] I have resolved CodeQL alerts
- [ ] I believe this CodeQL alerts is a false positive (merge team will evaluate)
- [ ] I am stuck (after reading instructions below)

<details><summary>Instructions</summary>

If CodeQL alert/annotations appear, refer to [How to Resolve CodeQL alerts](https://github.com/hackforla/website/issues/6463#issuecomment-2002573270).

In general, CodeQL alerts should be resolved prior to PR reviews and merging

</details>

### Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
<!-- Notes:
- If there are no visual changes to the website, delete all of the script below and replace with "- No visual changes to the website"
Expand Down