Removed ending slash from img tag #4517
Conversation
|
Availability: weekday evenings |
There was a problem hiding this comment.
Strange. Based on #4448 it asks specifically for
<img class="card-image" src="{{ item.image }}" alt=""/>
to be changed to
<img class="card-image" src="{{ item.image }}" alt="">
but the file you have looks different with it as
<img class="card-image" src="{{ item.card-image-src }}" alt="{{ item.card-image-alt }}"/>
To double check, can you ensure that you updated the gh-pages branch?
I hope a second reviewer can check this as well.
|
Availability - All day today |
There was a problem hiding this comment.
Hi @pdimaano! Looks like your PR has a merge conflict that you'll need to resolve before the PR can be merged. You did modify the correct line, but if you take a look here, that same line was updated: https://github.com/hackforla/website/blob/gh-pages/_includes/program-area-pages-cards.html
My only other suggestion is making sure your PR is added to the project board on the right-hand side of your PR. You can add it really easily by just clicking the little cog wheel and selecting the HfLA Project Board option.
Everything else looks good! You linked the proper issue, created the PR from your feature branch, and explained why the change was made. Good work!
There was a problem hiding this comment.
Thanks for fixing the merge issue. Now the changes you made in _includes/program-area-pages-cards.html reflects the changes needed mentioned in the issue you're working on.
This looks good, and you linked the proper issue, updated the PR from your feature branch, and explained why the change was made. Thanks!
Fixes #4448
What changes did you make and why did you make them ?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
No visual changes to the website.