Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change-linter-version-2479 #3667

Closed
wants to merge 1 commit into from
Closed

Change-linter-version-2479 #3667

wants to merge 1 commit into from

Conversation

esantiano
Copy link
Member

Fixes #2479

What changes did you make and why did you make them ?

  • checked @v4.8.3 to make sure that bug had been fixed.
  • changed line 22 "@v4.8.1 to @v4" after confirming the bug had been fixed.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

image

Visuals after changes are applied

image

@esantiano esantiano marked this pull request as ready for review October 26, 2022 22:37
@esantiano esantiano changed the title line22 changed from @v4.8.1 to @v4 Change-linter-version-2479 Oct 26, 2022
@arpitapandya arpitapandya added Bug Something isn't working role: back end/devOps Tasks for back-end developers Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 1pt Can be done in 4-6 hours labels Oct 28, 2022
@tunglinn tunglinn self-requested a review October 28, 2022 18:09
@tunglinn
Copy link
Member

ETA: tonight
Availability: 1hr

@tunglinn
Copy link
Member

For other reviewers:
git checkout -b esantiano-change-linter-version-2479 gh-pages
git pull https://github.com/esantiano/website.git change-linter-version-2479

@tunglinn
Copy link
Member

The checks didn't run for this PR. Is there a way to get it to run?
This is important because part of this PR is to make sure the linter works with the changes.

@arpitapandya
Copy link
Member

@esantiano Can we close this PR, and open a new one, please?
canyouclosetheprpleaseandcreatenew

@MattPereira MattPereira requested review from MattPereira and removed request for MattPereira October 28, 2022 19:39
@tunglinn tunglinn removed their request for review October 29, 2022 18:53
@esantiano esantiano closed this Oct 29, 2022
@esantiano esantiano deleted the change-linter-version-2479 branch October 29, 2022 21:12
@ExperimentsInHonesty ExperimentsInHonesty mentioned this pull request Dec 2, 2022
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Something isn't working Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours
Projects
P: HfLA Website: Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@esantiano @tunglinn @arpitapandya