Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create and apply header component #2002

Merged

Conversation

arghmatey
Copy link
Contributor

@arghmatey arghmatey commented Jul 23, 2021

Fixes #1898

What changes did you make and why did you make them ?

  • Created and applied class names for a specific header layout that is used across eight pages (About, Communities of Practice, Credits, Join Us, Programs Areas, Project Meetings, Sitemap, Toolkit).

  • Consolidated and refactored css code related to the header section into _containers.scss

  • Removed any unused css related to the old header. There was a lot of repetitive code spread across different files, so this was a pretty necessary clean up. Tested to make sure no other pages would be affected before removing code.

  • "About Us" link in header section needed a new class and css to be moved since it is different styling.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Screenshots provided are full page views

Desktop full length pages before changes were applied

About Us Before
Communities of Practice Before
Credits Before
Join Us Before
Program Areas Before
Project Team Meetings Before
Sitemap Before
Toolkit Before

Desktop full length pages after changes were applied

About Us Before After
Communities of Practice After
Credits After
Join Us After
Program Areas After
Project Team Meetings After
Sitemap After
Toolkit After

Tablet views after changes were applies

Using Toolkit and Project Team Meetings pages as examples
Toolkit Tablet After
Project Team Meetings After

Mobile views after changes were applies

Using Toolkit and Project Team Meetings pages as examples
Toolkit Mobile After
Project Team Meetings Mobile After

@github-actions github-actions bot added Feature: Design system role: front end Tasks for front end developers Complexity: Medium Status: Updated No blockers and update is ready for review labels Jul 23, 2021
@github-actions
Copy link

From your project repository, check out a new branch and test the changes.

git checkout -b arghmatey-header-container-component gh-pages
git pull https://github.com/arghmatey/website.git header-container-component

@Aveline-art Aveline-art requested review from Aveline-art and removed request for Aveline-art July 25, 2021 05:48
blakes24
blakes24 previously approved these changes Jul 30, 2021
Copy link
Member

@blakes24 blakes24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. It removes a lot of duplication, and the headers looked great across all screen sizes when I tested it out.

Copy link
Member

@Aveline-art Aveline-art left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to say that this is awesome and amazing work, @arghmatey ! There is so much attention to detail on this when comparing the website as it currently is, to our figma , to your changes. A++++ work! I will gladly merge this in a heartbeat, but I want to know your thoughts on some of the spacing:

Comparing it to the Figma designs, some of the margins/padding between the titles and the nav bar is off (most noticeable in the program area and team meetings page). Would you want to change them as part of this PR? Or do you feel it is better to make new issues out of them? I am fine with either, as the spacing is not too off.

@arghmatey
Copy link
Contributor Author

Thank you, @Aveline-art!

Nice catch on the spacing. Looks like right now the Credits page is off of the Figma file as well. I'll take a deep dive into it tomorrow morning to see what would be the best solution.

@arghmatey arghmatey marked this pull request as draft August 3, 2021 06:54
@arghmatey
Copy link
Contributor Author

arghmatey commented Aug 4, 2021

@Aveline-art This is ready for a final review now. Please let me know if you find anything else. Here's what I did:

  • Found the text side of the header should be justified to center of container. This causes the spacing on program areas, project meetings, and credits page because the height of the text is smaller than the image height.
  • I also had to change padding/margin dimensions on the second p tag since the bottom margin was adding to the spacing issues.

The only issue we are left with is the Sitemap page. Figma shows it should not be justified center like the other pages, but close to the navbar instead. I figure since it is one page against many, a new issue can be created to put it back in the right place.

Justified Center Screenshots

Credits
Program Areas
Project Team Meetings

Sitemap Now & Figma

Now
Figma

@arghmatey arghmatey marked this pull request as ready for review August 4, 2021 02:15
@arghmatey arghmatey force-pushed the header-container-component branch from f9c63a7 to 93c2730 Compare August 4, 2021 02:28
Aveline-art
Aveline-art previously approved these changes Aug 5, 2021
Copy link
Member

@Aveline-art Aveline-art left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome @arghmatey ! There is a merge conflict, but once that is dealt with, I can feel free to merge this.

@arghmatey
Copy link
Contributor Author

Thanks, @Aveline-art. Merge conflict resolved!

Copy link
Member

@Aveline-art Aveline-art left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks gorgeous! Thank you for the hard work!

@Aveline-art Aveline-art merged commit 49f5724 into hackforla:gh-pages Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium Feature: Design system role: front end Tasks for front end developers Status: Updated No blockers and update is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardize code for header layout
3 participants