Standardizing page card classes and properties across the site to comply with design system #1277
Conversation
…sses to cards scss file
There was a problem hiding this comment.
Sorry about the delay on this review.. I notice that there is a merge conflict, hit me up if you want a hand fixing that...
Everything either looks the same or better..
I did noticed this..
new credits page in mobile view
current credits page in mobile view
Super duper impressive pr!! this was comprehensive! You also made the getting-started and getting-started-with-video pages transition much better.. hats off
|
@jbubar no worries, I know this is a huge pull request, sorry about that! Thank you so much for taking the time to review- Yes, I could use some help with the merge conflict when you have time, thank you! And good catch with the credits page mobile view- it's relatively minor and the credits page isn't connected to the site yet, so I can make an issue to fix that after this is merged.. |
|
I feel good about merging this, after we fix the merge conflicts |
Fixes #958
As the next step (after buttons) in standardizing the HfLA site's reusable components according to the design system, I standardized the page cards across the site to use the same handful of reusable class names, according to this logic.
If all of the page cards edited here still look pretty much the same as they currently do on the website (in both desktop and mobile), that means this pull request is successful.
I added reusable classes to the _cards.scss file with explanations, and changed the page card classes in the scss and html files of the pages listed below. (FYI the Join, Sitemap, and Communities of Practice pages were built after the design system, so I had already asked to use some of the reusable page card classes)
Page cards from the following pages are edited here:
Homepage
Getting Started
Project Description page
Projects meetings page
Join page
Communities of Practice page
Sitemap page
Credits page
I left out the Guide page cards for now because those pages are going through a big transition, so that will be standardized when it's time. I also left out the About page cards for now because they haven't yet been standardized (they are off-center with the side sticky nav, so it's a special case and will need to be standardized with the upcoming Open Roles page, with a similar side sticky filter).