Skip to content

Conversation

@fyliu
Copy link
Member

@fyliu fyliu commented Sep 4, 2025

Fixes #529

What changes did you make?

  • auto upgrade python dependencies in pre-commmit commented out
  • upgrade python dependencies
  • update uv version in Dockerfile
  • remove extra line in uv docs page

Why did you make the changes (we will use this info to test)?

  • Commented out the auto upgrade python dependencies hook with a reason, in case one of us rediscovers and wants to add it. We can enable it if the reasoning is no longer as relevant.
  • Updating software versions to for feature set and security
  • Other are changes or cleanup related to the main change.

Testing

  • The code should still build, run, lint, and pass all tests. So basically the precommit-check.sh script should finish without error.

@fyliu fyliu moved this to PR Needs review (automated column, do not place items here manually) in P: PD: Project Board Sep 4, 2025
@fyliu fyliu force-pushed the 529-update-python-dependencies branch from 9204973 to 8718d43 Compare September 4, 2025 23:34
@fyliu fyliu self-assigned this Sep 5, 2025
@fyliu fyliu force-pushed the 529-update-python-dependencies branch 2 times, most recently from 8ce9b53 to 569be8c Compare September 16, 2025 04:44
@fyliu fyliu marked this pull request as draft September 18, 2025 22:39
@fyliu
Copy link
Member Author

fyliu commented Sep 18, 2025

Converting to draft because I'm not sure if this is a good idea to have. It could generate a good amount of changes if it checks and updates requirements.txt really often. Maybe it's better as a manual script or encoded in to a GHA on a schedule.

@fyliu fyliu force-pushed the 529-update-python-dependencies branch 2 times, most recently from ed44639 to 3c468cc Compare November 9, 2025 05:35
@fyliu fyliu changed the title ci: auto upgrade python dependencies upgrade python dependencies Nov 9, 2025
@fyliu fyliu marked this pull request as ready for review November 9, 2025 05:39
@fyliu
Copy link
Member Author

fyliu commented Nov 9, 2025

This is ready for review.
I didn't remove the automatic update hook but commented it out to show that it was considered and not used.

@fyliu fyliu changed the title upgrade python dependencies Upgrade python dependencies Nov 9, 2025
- added a disabled python dependencies update automation and why
- removed extra line from docs about upgrading python dependencies
@fyliu fyliu force-pushed the 529-update-python-dependencies branch from 3c468cc to c689f66 Compare November 30, 2025 08:22
Copy link
Member

@Ruchitha12 Ruchitha12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran pre-commit check locally. All hooks passed with the updated dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: PR Needs review (automated column, do not place items here manually)

Development

Successfully merging this pull request may close these issues.

Update python dependencies

2 participants