Skip to content

Unit testing for User model #1955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 29, 2025
Merged

Unit testing for User model #1955

merged 9 commits into from
Jul 29, 2025

Conversation

@jng34
Copy link
Member

@jng34 jng34 commented Jun 4, 2025

Fixes #1951

What changes did you make and why did you make them ?

  • Wrote unit tests for User model
  • Checked for serialization and validation

Screenshot of passed tests

passed-tests

@JackHaeg JackHaeg mentioned this pull request Jun 10, 2025
Open
dannyprikaz
dannyprikaz requested changes Jun 17, 2025
View reviewed changes
Copy link
Member

@dannyprikaz dannyprikaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, James. Sorry for the late review on this. Maybe we should discuss in the meeting tonight, but I think that my comments should provide the right approach to unit testing models without creating a MongoMemoryServer

@dannyprikaz dannyprikaz mentioned this pull request Jul 11, 2025
Closed
2 tasks
dannyprikaz
dannyprikaz requested changes Jul 15, 2025
View reviewed changes
jng34
jng34 commented Jul 15, 2025
View reviewed changes
Copy link
Member Author

@jng34 jng34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented the requested changes.

@JackHaeg
Copy link
Member

@dannyprikaz Can you please review this PR when you have a moment? Once reviewed / merged, we can then unblock work on #1979

@JackHaeg
Copy link
Member

Hi @dannyprikaz! Just checking in again - Can you please review this PR when you have a moment? Once reviewed / merged, we can then unblock work on #1979

@JackHaeg JackHaeg mentioned this pull request Jul 29, 2025
Merged
dannyprikaz
dannyprikaz approved these changes Jul 29, 2025
View reviewed changes
Copy link
Member

@dannyprikaz dannyprikaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dannyprikaz dannyprikaz merged commit de14c9d into hackforla:development Jul 29, 2025
2 of 5 checks passed
@jng34 jng34 deleted the unitTestingForUserModel branch July 29, 2025 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dannyprikaz dannyprikaz dannyprikaz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create New Unit Tests for ./backend/models/user.model.js

3 participants

@jng34 @JackHaeg @dannyprikaz