-
-
Notifications
You must be signed in to change notification settings - Fork 97
Create unit tests for users.router.js and move integration tests #1882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create unit tests for users.router.js and move integration tests #1882
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
@jng34 Given that you are also working on unit tests issues, we would love for you to take a crack at reviewing this PR from @dannyprikaz! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dannyprikaz All unit tests passed. Great use of comments and good template for writing future tests!
|
@dannyprikaz given that we have @jng34 approval, please feel free to go ahead and merge this PR whenever you have a moment. Would love for you to get the GitHub credit for this one! |
|
Hey, @jng34 I figured out how to test specific expectations of request bodies and url parameters that are passed to controller methods. This should make our tests more complete. Could you please review this one more time. I'm going to include the technique that I learned on PRs that I'm reviewing from you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dannyprikaz
The changes are definitely more complete now, given that you're now able to parse the incoming data. Great work!
|
@JackHaeg |
Fixes #1881
What changes did you make and why did you make them ?
users.router.jstobackend/test/directoryusers.router.jsthat isolate the behavior of the router from its dependencies