Skip to content

Convert Events.js to MUI Components #1869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
May 20, 2025
Merged

Convert Events.js to MUI Components #1869

merged 11 commits into from
May 20, 2025

Conversation

@sasszz
Copy link
Member

@sasszz sasszz commented Mar 7, 2025 •
edited
Loading

Fixes #1711

How to access component (thank you @hollydo !)

  1. Login to VRMS
  2. go to http://localhost:3000/event/2
  3. Click Back To Events

What changes did you make and why did you make them ?

  • Convert div to Box
  • Convert ul to List
  • Convert li to ListItem
  • Convert input to Textfield
  • Remove unused CSS
  • Added state for Loading and No returned events

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Screenshot 2025-03-14 at 9 50 29 AM Screenshot 2025-03-14 at 10 11 11 AM Screenshot 2025-03-14 at 9 47 02 AM

@sasszz sasszz marked this pull request as ready for review March 7, 2025 05:35
@hollydo hollydo self-requested a review March 11, 2025 02:10
@hollydo

This comment was marked as resolved.

Sign in to view
hollydo
hollydo requested changes Mar 11, 2025
View reviewed changes
@sasszz sasszz requested a review from hollydo March 14, 2025 18:22
@JackHaeg JackHaeg mentioned this pull request Mar 18, 2025
Open
hollydo
hollydo approved these changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@hollydo hollydo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job Lucie, thanks for adding the extra loading text!

@sasszz sasszz added ready for dev lead Add to issue when dev lead needs to take some action ready for 2nd review When a PR is ready for another reviewer labels Mar 19, 2025
dannyprikaz

This comment was marked as resolved.

Sign in to view

@JackHaeg
Copy link
Member

Hi @sasszz just tagging you here! Please see @dannyprikaz comment above with a small change request. Once this is complete, we can go ahead and get this merged!

Thanks :)

sasszz
sasszz commented May 19, 2025
View reviewed changes
@sasszz sasszz dismissed dannyprikaz’s stale review May 20, 2025 01:44

Issue Resolved, CSS added back in

@sasszz
Copy link
Member Author

sasszz commented May 20, 2025

All issues resolved, awaiting final review and merge, thank you!

@sasszz sasszz requested a review from dannyprikaz May 20, 2025 01:45
dannyprikaz
dannyprikaz approved these changes May 20, 2025
View reviewed changes
Copy link
Member

@dannyprikaz dannyprikaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sasszz sasszz merged commit ae5b57e into hackforla:development May 20, 2025
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hollydo hollydo hollydo approved these changes

@dannyprikaz dannyprikaz dannyprikaz approved these changes

Assignees

No one assigned

Labels

ready for dev lead Add to issue when dev lead needs to take some action ready for 2nd review When a PR is ready for another reviewer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update HTML components to MUI: ./src/pages/Events.js

4 participants

@sasszz @hollydo @JackHaeg @dannyprikaz