Skip to content

Conversation

@sasszz
Copy link
Member

@sasszz sasszz commented Jan 23, 2025

Fixes #1699

What changes did you make and why did you make them ?

  • Refactored EventForm to use Material UI Form Components
  • Commented out global styles that conflict with Material UI components
  • Added a Title for editing a meeting

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied Screenshot 2025-01-29 at 9 40 32 PM Screenshot 2025-01-29 at 9 40 39 PM
Visuals after changes are applied Screenshot 2025-01-29 at 9 41 11 PM Screenshot 2025-01-29 at 9 41 18 PM

@sasszz sasszz changed the title Init Commit + Notes + Example Input EventForm Refactor to Material UI Jan 30, 2025
@sasszz sasszz marked this pull request as ready for review January 30, 2025 05:51
@sasszz sasszz requested review from JackHaeg and trillium January 30, 2025 05:52
@sasszz sasszz self-assigned this Jan 30, 2025
dannyprikaz

This comment was marked as resolved.

@sasszz

This comment was marked as resolved.

Copy link
Member

@dannyprikaz dannyprikaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. As long as @trillium is good with the CSS solution, I approve.

@sasszz
Copy link
Member Author

sasszz commented Feb 7, 2025

if approved, i would like the opportunity to merge this pr, thank you!

@JackHaeg JackHaeg added the ready for dev lead Add to issue when dev lead needs to take some action label Feb 11, 2025
@JackHaeg
Copy link
Member

@trillium Please take a look at this when you have a moment (global styles)

Copy link
Member

@trillium trillium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks!

Chatting on the Zoom call yesterday was helpful, I appreciate you mentioning that if we're overhauling styles, global styles are going to need to be revamped anyway.

@trillium trillium merged commit e2ec0fe into hackforla:development Feb 11, 2025
3 of 6 checks passed
@sasszz sasszz deleted the lucie-1699-eventform-mui branch February 11, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

complexity: small ready for dev lead Add to issue when dev lead needs to take some action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update HTML components to MUI: ./src/components/manageProjects/eventForm.js

4 participants