Skip to content

Conversation

@jng34
Copy link
Member

@jng34 jng34 commented Jan 21, 2025

Fixes #1717

What changes did you make and why did you make them ?

  • Replaced HTML form tag with MUI FormControl component
  • Replaced HTML label tag with MUI Typography component
  • Replaced HTML select tag with MUI Select component, and mapped each event onto a MenuItem component
  • Removed old style of adding a --Select One-- option; made it the default value for the MUI Select component
  • Added CSS styling to match original CSS for HTML components
  • WHY: To modernize frontend components with MUI

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied before screen 1 before screen 2 before screen 3
Visuals after changes are applied after screen 1 after screen 2 after screen 3

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b jng34-updateHTMLtoMUIforHomeComp development
git pull https://github.com/jng34/VRMS.git updateHTMLtoMUIforHomeComp

@jng34 jng34 added ready for 2nd review When a PR is ready for another reviewer waiting to merge labels Mar 11, 2025
@trillium trillium force-pushed the updateHTMLtoMUIforHomeComp branch from b0037cf to 7e94afd Compare May 13, 2025 02:29
@jng34 jng34 force-pushed the updateHTMLtoMUIforHomeComp branch from 7e94afd to 591a238 Compare May 13, 2025 02:38
@bconti123 bconti123 self-requested a review May 27, 2025 23:44
Copy link
Member

@bconti123 bconti123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at code and tested out the website. The MUI components look good to me!

@jng34 jng34 merged commit 0ab315f into hackforla:development Jun 3, 2025
3 of 5 checks passed
@jng34 jng34 deleted the updateHTMLtoMUIforHomeComp branch September 23, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

complexity: small ready for 2nd review When a PR is ready for another reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update HTML components to MUI: ./src/pages/Home.js

4 participants