Skip to content

Conversation

@nora-zajzon
Copy link
Member

@nora-zajzon nora-zajzon commented Jul 17, 2024

Fixes #1665
Fixes #1640
#1641

What changes did you make and why did you make them ?

  • Replaced all HTML components with MUI components in /src/components/manageProjects/editMeetingTimes.js

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b nora-zajzon-editMeetingTimes development
git pull https://github.com/nora-zajzon/VRMS.git editMeetingTimes

@trillium trillium changed the title Replaced HTML with MUI applicable components editMeetingTimes - Replaced HTML with MUI applicable components Aug 5, 2024
Copy link
Member

@trillium trillium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to approve these changes for editMeetingTimes.js

The other file changes have beeen approved as well though they're from other PRs (fine for now).

We will need to revisit this component in the future to use a modal provided by MUI, but that is outside the scope of this PR. Thank you!

@trillium
Copy link
Member

trillium commented Aug 5, 2024

@JackHaeg can I ping you to track that this component needs to be transferred to a modal provided by MUI? I think we already have an issue open for it

@JackHaeg
Copy link
Member

JackHaeg commented Aug 7, 2024

@trillium to create tracking issue

@JackHaeg
Copy link
Member

JackHaeg commented Aug 8, 2024

@nora-zajzon nora-zajzon changed the title editMeetingTimes - Replaced HTML with MUI applicable components Replaced HTML with MUI applicable components in multiple files Nov 19, 2024
@JackHaeg
Copy link
Member

@trillium Please take a look at this to check for duplicate work. Since this is fixing multiple issues, and some of the issues have been tackled by other members, we might be grabbing specific commits from this PR and merging those.

@JackHaeg JackHaeg added the ready for dev lead Add to issue when dev lead needs to take some action label Feb 25, 2025
@JackHaeg
Copy link
Member

JackHaeg commented Mar 4, 2025

@trillium Please take a look at this to check for duplicate work. Since this PR is fixing multiple issues, and some of the issues have been tackled by other members, we might be grabbing specific commits from this PR and merging those.

@JackHaeg
Copy link
Member

JackHaeg commented May 8, 2025

Per @trillium's direction, we are closing this PR due to merge conflicts and duplicate changes that will be difficult to overcome due to more recent edits on VRMS. This PR will be used as a reference when creating an updated fresh PR should be submitted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

complexity: small ready for dev lead Add to issue when dev lead needs to take some action

Projects

None yet

3 participants