-
-
Notifications
You must be signed in to change notification settings - Fork 97
Replaced HTML with MUI applicable components in multiple files #1702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to approve these changes for editMeetingTimes.js
The other file changes have beeen approved as well though they're from other PRs (fine for now).
We will need to revisit this component in the future to use a modal provided by MUI, but that is outside the scope of this PR. Thank you!
|
@JackHaeg can I ping you to track that this component needs to be transferred to a modal provided by MUI? I think we already have an issue open for it |
|
@trillium to create tracking issue |
|
|
@trillium Please take a look at this to check for duplicate work. Since this is fixing multiple issues, and some of the issues have been tackled by other members, we might be grabbing specific commits from this PR and merging those. |
|
@trillium Please take a look at this to check for duplicate work. Since this PR is fixing multiple issues, and some of the issues have been tackled by other members, we might be grabbing specific commits from this PR and merging those. |
|
Per @trillium's direction, we are closing this PR due to merge conflicts and duplicate changes that will be difficult to overcome due to more recent edits on VRMS. This PR will be used as a reference when creating an updated fresh PR should be submitted |
Fixes #1665
Fixes #1640
#1641
What changes did you make and why did you make them ?