Refactor AdminDashboard component to use Material-UI Typography for h…

[chukalicious]

Fixes #1671

What changes did you make and why did you make them ?

• the task required the change of regular html elements for their MUI equivalents, if applicable. Hence, I imported the Typography component from MUI and implemented it in place of the h1 component in the line 390. I implemented the variant and component properties as "h1".
• It appears some formatting changes were also performed by my formatting extension.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

Visuals after changes are applied

[github-actions]

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b chukalicious-1671-update-html-components-to-mui-srccomponentsadmindashboardindexjs development
git pull https://github.com/chukalicious/VRMS.git 1671-update-html-components-to-mui-srccomponentsadmindashboardindexjs

[trillium]

Hey @chukalicious , thanks for your work on this PR!

I'm going to approve it, but in the future I'd like to call you attention to how adding in automatically linted changes makes the job of pull request reviewers more difficult:

Link to files changes for this PR

No worries about it at the moment, this project doesn't have a set linting standard so everyone's linter will do these sorts of things. The best way to combat it is to add changes individually rather than adding all the changes to a file total.

This can be achieved by usiing git add -p {file}, or by using VSCode directly to add sections of code to your pr.

Thanks for your hard work!

[vorleakyek]

@trillium, @chukalicious, should we add style to fit the header in one line as before? The old style looks better than the new one. Also, we don't need to convert div with texts inside to typography. Is that correct?

For example : <div className="event-header">Current event:</div>

[JackHaeg]

@trillium to review and remove linting changes

[JackHaeg]

@trillium Just checking in on this PR review :) Can you please take a look at it when you have a moment and review / remove linting changes as we discussed previously?

[JackHaeg]

Hi @trillium! Just checking in again - when you have a moment this week, can you please review this PR / remove linting changes?

[trillium]

Did my best to undo the linting stuff, turns out it was a fools errand. Sorry for holding this up so long!

[trillium]

Turns out after all that complaining this PR isn't compatible with our repo any longer since changing the extension to .jsx.

Closing and adding the ticket back to the backlog