generated from hackforla/.github-hackforla-base-repo-template
-
-
Notifications
You must be signed in to change notification settings - Fork 21
Updated API Endpoints for Intake Profile and Dynamic Forms #866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
johnwroge
wants to merge
11
commits into
main
Choose a base branch
from
intake_profile_endpoints
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulespinosa
approved these changes
Mar 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried the code locally. Looks good.
import json | ||
with open("form_data/form1.json", "r") as f: | ||
FORM_1 = json.load(f) | ||
FORM_1['id'] = 'guest' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be able to change the json in the file to have id guest/host.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a work in progress. We haven't met as a group in a few weeks so please provide feedback, or feel free to message me on slack so I can make needed changes.
What changes did you make?
Rationale behind the changes?
Dynamic forms are being implemented to display application information. This approach is intended for both Host and Guest applications, reducing the need for custom form components and promoting code reuse.
Testing done for these changes
Testing will be completed once the functionality is confirmed.
What can you share that is new?
Note I believe there are a number of changes needed including:
The path from the guest dashboard using the correct group id and profile id.
// Old url: 'profile/1/group/1' vs New url: 'profile/guest'
the userId vs profileType in api requests
'/api/intake-profile/responses/:profile_type' vs '/api/intake-profile/responses/:userId',
The paths were updated to 'guest' and 'host' from 1 and 2 for readability, but will be changed to user ids.
Guest Application

Host Application
