Skip to content

Conversation

@edwinjue
Copy link
Member

@edwinjue edwinjue commented Jan 31, 2023

Hi @bryantran04 @hqasmei

Per Bonnie, I went ahead an implemented a landing page to notify prod site visitors that our site is currently under maintenance. More info can be found in #1441

Please take a look when you have a chance and let me know if there is anything I may have overlooked.

If you want to take a look on localhost, simply checkout this branch by executing from the 311-data project directory:
git checkout --track master-maint

Also, I notice our github actions workflow for frontend prod is a little different and looks like the trigger is a push instead of a pull-request so If I'm not mistaken, an update to the prod site should take place when we git push to master. Is this your understanding as well?

Thanks in advance for taking a look.

Fixes #1441

  • Up to date with master branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

Any questions? See the getting started guide

@edwinjue edwinjue linked an issue Jan 31, 2023 that may be closed by this pull request
5 tasks
Copy link
Member

@bryantran04 bryantran04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bryantran04 bryantran04 merged commit cdde80a into master Jan 31, 2023
@bryantran04 bryantran04 deleted the master-maint branch January 31, 2023 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Need to take down current prod site and replace with a landing page

3 participants