Skip to content

Align tabletop column processing with hackfoldr 1.0. #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2016

Conversation

MrOrz
Copy link
Contributor

@MrOrz MrOrz commented Feb 7, 2016

原本舊版 hackfoldr 的第一列的字亂打也沒關係,但 hackfoldr 2.0 裡面,第一列一定要取名為「url」「title」「foldrexpand」 「編輯註解」與「hints」。

這個 PR 把行為改回跟舊版 hackfoldr 一致。

Breaking change:如果有 hackfoldr 的欄位順序跟舊版不同、仰賴第一列的欄位名字的話,那麼 merge 這個 PR 之後,該 hackfoldr 就會壞掉。若原本 hackfoldr 2.0 是故意設計成要使用第一列的欄位名稱、讓使用者可以自訂欄位順序的話,請不要 merge 而直接 close 此 PR。

@irvin
Copy link
Contributor

irvin commented Feb 26, 2016

@ETBlue 這邊我覺得怪怪的,有這個限制嗎?

@MrOrz
Copy link
Contributor Author

MrOrz commented Feb 27, 2016

@irvin 我也覺得很怪,但 code 是這樣寫沒錯 @@
請見舊的 619 - 623 行:
MrOrz@0480713#diff-e01b6ad9b35cb8d9a7997e114a30a3f7L622

git blame 說這幾行的原作者是 @caasi

@caasi
Copy link
Member

caasi commented Feb 27, 2016

@MrOrz 事由: http://logbot.g0v.tw/channel/g0v.tw/2014-08-01#622

當時是為了0801高雄氣爆資訊而寫死的: ks0801

@MrOrz
Copy link
Contributor Author

MrOrz commented Feb 28, 2016

@caasi 喔喔喔一切都說得通了!

Tabletop 的文件好像有很多東西都沒寫,我是用 console.log 去挖才發現有 models[].column_names 可以用 xd

caasi Huang notifications@github.com 於 2016年2月28日週日 上午6:58 寫道:

@MrOrz https://github.com/MrOrz 事由:
http://logbot.g0v.tw/channel/g0v.tw/2014-08-01#622

當時是為了0801高雄氣爆資訊 http://beta.hackfoldr.org/Kaohsiung-explode-20140801/而寫死的:
ks0801
https://docs.google.com/spreadsheets/d/1WVWrKC-Tbry3ltgouQPpZH2Cd2HkKeZ8DjLs4PWa1z4/edit#gid=0


Reply to this email directly or view it on GitHub
#11 (comment)
.

@ETBlue
Copy link
Member

ETBlue commented Feb 28, 2016

啊啊啊信件太多了沒看到這個 orz 沒有,當初沒有要故意設計可以對調欄位,單純是我不會用 tabletop 跑到馬路上喊救命然後 caasi 就隨手解完了,當時狀況緊急,也沒時間想太多 XD 大家都有權限啊怎麼這麼客氣... 那我要按綠色按鈕了喔(擦掌)

ETBlue added a commit that referenced this pull request Feb 28, 2016
Align tabletop column processing with hackfoldr 1.0.
@ETBlue ETBlue merged commit cd86881 into hackfoldr:master Feb 28, 2016
@irvin
Copy link
Contributor

irvin commented Feb 28, 2016

啪啪啪啪啪

@MrOrz MrOrz deleted the fix-tabletop branch February 29, 2016 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants