Skip to content

Conversation

@rossmanko
Copy link
Contributor

@rossmanko rossmanko commented Dec 6, 2025

  • Add symlink from testssl to testssl.sh in Dockerfile for better UX
  • Place symlink creation before validation for proper testing
  • Detect both 'tail --pid' and 'while ps -p' wait patterns
  • Extend timeout to 7 minutes for wait commands (vs 60s default)
  • Guide AI to use tail --pid while handling while loops as fallback
  • Use dynamic timeout values in instructions from constants

Summary by CodeRabbit

  • Removed Features

    • Removed support for Clairvoyance, TplMap, and PHPGGC tools from Docker image.
  • New Features

    • Added TestSSL tool integration with symlink wrapper.
  • Bug Fixes

    • Improved background process detection with enhanced timeout differentiation and user-friendly status messaging.

✏️ Tip: You can customize this high-level summary in your review settings.

- Add symlink from testssl to testssl.sh in Dockerfile for better UX
- Place symlink creation before validation for proper testing
- Detect both 'tail --pid' and 'while ps -p' wait patterns
- Extend timeout to 7 minutes for wait commands (vs 60s default)
- Guide AI to use tail --pid while handling while loops as fallback
- Use dynamic timeout values in instructions from constants
@vercel
Copy link

vercel bot commented Dec 6, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
hackerai Ready Ready Preview Comment Dec 6, 2025 4:58pm

@rossmanko rossmanko merged commit fa64725 into main Dec 6, 2025
3 of 4 checks passed
@coderabbitai
Copy link

coderabbitai bot commented Dec 6, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Changes remove deprecated tool setup blocks (clairvoyance, tplmap, phpggc) from the Dockerfile while introducing TestSSL symlink wrapper support. The terminal command runner is enhanced to detect PID waits using dual patterns (tail and ps-based) with differentiated timeout logic.

Changes

Cohort / File(s) Summary
Dockerfile cleanup and TestSSL addition
docker/Dockerfile
Removed Git-based setup for clairvoyance, tplmap, and phpggc tools along with their wrapper creation logic; retained JWT tool wrapper; added conditional TestSSL symlink creation (testssl.sh) and validation checks
Terminal command runner PID/timeout enhancements
lib/ai/tools/run-terminal-cmd.ts
Enhanced PID wait detection with dual patterns (tail --pid and while ps -p); differentiated timeout logic between short (STREAM_TIMEOUT_SECONDS) and long (MAX_COMMAND_EXECUTION_TIME) waits; updated messaging to document extended timeout behavior

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • Dockerfile cleanup: Verify all removed tool references are no longer needed; confirm TestSSL symlink logic is correct and doesn't break existing workflows
  • Terminal command runner: Review dual PID detection patterns for robustness; validate timeout differentiation logic handles edge cases correctly; ensure PID extraction works with both tail and ps patterns

Possibly related PRs

Poem

🐰 Old tools fade away like morning dew,
Clairvoyance, TplMap—adieu, adieu!
TestSSL rises with symlink grace,
While PID detection finds its place,
Tail and ps now dance as one,
The refactor's journey has begun! 🔧

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch daily-branch-2025-12-05

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 18f9157 and ce8096c.

📒 Files selected for processing (2)
  • docker/Dockerfile (3 hunks)
  • lib/ai/tools/run-terminal-cmd.ts (2 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai bot mentioned this pull request Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants