Skip to content

Comments

Fix transfer flash#12998

Open
manuthecoder wants to merge 3 commits intomainfrom
mxg-fix-transfer-flash
Open

Fix transfer flash#12998
manuthecoder wants to merge 3 commits intomainfrom
mxg-fix-transfer-flash

Conversation

@manuthecoder
Copy link
Contributor

Fixes flash being hidden by navbar

image

This comment was marked as spam.

@@ -1,5 +1,6 @@
<% page_full %>
<% @no_app_shell = true %>
<% @hide_flash = true %>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

app/views/layouts/application.html.erb

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should phase out using instance variables like this in the future but it's fine for now.

Copy link
Contributor

@Luke-Oldenburg Luke-Oldenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants