-
Notifications
You must be signed in to change notification settings - Fork 16
Adds SMS auth endpoints #454
Conversation
a5842b4
to
8df7cfd
Compare
Rails.application.secrets.twilio_account_sid, | ||
Rails.application.secrets.twilio_api_key | ||
) | ||
VERIFY_SERVICE_ID = 'VAa06a66dad4c1ca3c199a46334ff11945' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this isn't private so it's okay to just hardcode it here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a comment above that line that so someone doesn't put it in secrets later?
@tanatorn This is looking great. When I look at this recording, the code feels hard to read in a push-notification. Is there a way to shorten the code or add a hyphen in the middle to help mentally break it down? |
Also, is the bank user going to get an sms & email at the same time? Will the codes be the same? |
@maxwofford, unfortunately the text message is controlled fully by Twilio, there's nothing I can do there to change that. Additionally, it'll either go to SMS or Email. However, we don't manage any state on the SMS side, e.g. we'll generate a new user token, but we won't touch the |
PTAL @maxwofford |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Please add the heroku env keys before merge if you haven't yet.
I have a couple questions about user experience I'll leave on the bank PR.
done! |
Adds the API endpoints required to actually do SMS auth, there will be a PR on the bank repo to actually do the hooking up of bank.hackclub.com to this.
Notable things: