Skip to content
This repository has been archived by the owner on Feb 28, 2023. It is now read-only.

Commit

Permalink
Remove SendApplicationToAirtableJob
Browse files Browse the repository at this point in the history
  • Loading branch information
zachlatta committed Aug 6, 2019
1 parent 09dd907 commit 8c25923
Show file tree
Hide file tree
Showing 8 changed files with 1 addition and 220 deletions.
3 changes: 0 additions & 3 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,6 @@ jobs:
SCREENSHOTLAYER_API_KEY: fake_api_key

MLH_LHD_API_KEY: fake_api_key

AIRTABLE_KEY: ENV-airtable_key
AIRTABLE_BASE: ENV-airtable_base

# Service container image available at `host: localhost`

Expand Down
3 changes: 0 additions & 3 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,6 @@ gem 'terminal-table', '~> 1.7'
gem 'timezone', '~> 1.0'
gem 'wkhtmltopdf-binary', '~> 0.12.3'

# Reason we're importing from GitHub: https://github.com/Airtable/airtable-ruby/issues/14#issuecomment-281893486
gem 'airtable', github: 'Airtable/airtable-ruby'

gem 'rails_autoscale_agent', '~> 0.3.1'

group :development, :test do
Expand Down
12 changes: 0 additions & 12 deletions Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,11 +1,3 @@
GIT
remote: git://github.com/Airtable/airtable-ruby.git
revision: 041a8baf8ae59279630912d6ff329faa64398cb2
specs:
airtable (0.1.1)
activesupport (>= 3.0)
httparty (~> 0.14.0)

GEM
remote: https://rubygems.org/
specs:
Expand Down Expand Up @@ -144,8 +136,6 @@ GEM
htmlentities (4.3.4)
http-cookie (1.0.3)
domain_name (~> 0.5)
httparty (0.14.0)
multi_xml (>= 0.5.2)
i18n (1.3.0)
concurrent-ruby (~> 1.0)
jmespath (1.4.0)
Expand Down Expand Up @@ -174,7 +164,6 @@ GEM
mini_portile2 (2.4.0)
minitest (5.11.3)
msgpack (1.2.4)
multi_xml (0.6.0)
multipart-post (2.0.0)
nenv (0.3.0)
netrc (0.11.0)
Expand Down Expand Up @@ -354,7 +343,6 @@ PLATFORMS

DEPENDENCIES
active_model_serializers (~> 0.10.2)
airtable!
analytics-ruby
aws-sdk-s3 (~> 1.8, >= 1.8.2)
bootsnap (~> 1.3)
Expand Down
41 changes: 0 additions & 41 deletions app/jobs/send_application_to_airtable_job.rb

This file was deleted.

4 changes: 0 additions & 4 deletions app/models/new_club_application.rb
Original file line number Diff line number Diff line change
Expand Up @@ -113,10 +113,6 @@ def submit!
end

ApplicantMailer.application_submission_staff(self).deliver_later

# Send to Zapier
SendApplicationToAirtableJob.perform_later(self)

ApplicantMailer.application_submission_json(self).deliver_later

true
Expand Down
3 changes: 0 additions & 3 deletions config/secrets.yml
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,6 @@ common: &common
# MLH Local Hack Day API Key
mlh_lhd_api_key: <%= ENV.fetch("MLH_LHD_API_KEY") %>

airtable_key: <%= ENV.fetch("AIRTABLE_KEY") %>
airtable_base: <%= ENV.fetch("AIRTABLE_BASE") %>

development:
<<: *common
secret_key_base: 6d02f9126a44347e07442fddf774b6a434a85b86e23629eab947c9c101b8aa878ad8fe5dadba26a3341f1a16f480068ae5234861cb7b913f526a0e96a21fcc7d
Expand Down
4 changes: 1 addition & 3 deletions spec/models/new_club_application_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -315,9 +315,7 @@
end

it 'sends confirmation emails to applicants and staff' do
VCR.use_cassette('airtable') do
perform_enqueued_jobs { subject.submit! }
end
perform_enqueued_jobs { subject.submit! }

# three emails to applicants and two to staff (regular & JSON)
expect(ApplicantMailer.deliveries.length).to eq(3 + 2)
Expand Down
151 changes: 0 additions & 151 deletions spec/vcr/airtable.yml

This file was deleted.

0 comments on commit 8c25923

Please sign in to comment.