Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing newline in bot #419

Merged
merged 3 commits into from
Mar 29, 2024
Merged

Missing newline in bot #419

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e499255
accidentally added files to root
karmanyaahm Mar 17, 2024
0b7c7fa
missing newline problem
karmanyaahm Mar 29, 2024
65783b7
Merge branch 'main' into main
karmanyaahm Mar 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'main' into main
  • Loading branch information
@karmanyaahm
karmanyaahm authored Mar 29, 2024
commit 65783b7ec77c8c4673f18f49cc7911756fe18af1
10 changes: 5 additions & 5 deletions .github/workflows/gerbview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,12 +128,12 @@ Required files
|✅| README.md | A description of your project |
|${(await hasCart(readme)) ? "✅" : "❌"} | cart.png | ${(await hasCart(readme))
? "![cart.png](<https://raw.githubusercontent.com/hackclub/OnBoard/" +
(await currentCommitHash()) +
"/" +
path.dirname(readme) +
"/cart.png>)"
(await currentCommitHash()) +
"/" +
path.dirname(readme) +
"/cart.png>)"
: "You need to include a screenshot of your JLCPCB. Check out [these instructions](https://github.com/hackclub/OnBoard/blob/main/docs/ordering_from_JLCPCB.md#pcb-review). If you already have one, make sure it's a PNG file named exactly \"cart.png\"."
} |`; // TODO: can we handle both png and jpg/jpeg??
} |`; // TODO: can we handle both png and jpg/jpeg??

let gerbers = await gerbersInDir(path.dirname(readme));

Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.