-
Couldn't load subscription status.
- Fork 6
Fix: Improve Local Development Setup and Docker Stability #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Improve Local Development Setup and Docker Stability #23
Conversation
|
Additionally pushed dd6c46d so transmitter can pick up changes in config.yml with container restart (unless it was a design choice where changes in config.yml doesn't get picked up by live transmitter unless built anew) :) |
a95b492 to
dd6c46d
Compare
|
Hey team, While integrating with DataStreamsFeed.sol we realised our transmitter function updateReport(
uint16 reportVersion,
bytes calldata verifiedReportData
) external onlyRole(Roles.REPORT_VERIFIER);What was missing
What’s new in 9fe3951
Why it mattersWith the extra fields present the transmitter can encode and send Thanks! |
|
Hey team, Two quick README tweaks in this PR:
Tiny change, but it should save newcomers a lot of setup questions. Thanks! |
|
Hey team, apologies on having too many lengthened PR thread - note that this pr was supposed to be limited to minor fixes / chores but - while trying to add support to our worldchain live contract (aka Adriasta's contract - happened to be a bit messier pr than expected. on to the point - two updates with: b63c019
Should make setup choices much clearer with minimal code churn. Thanks! |
|
Thank you for your contribution. We've fixed some of the issues identified in your PR in the previous PR #17 which is currently undergoing security review. We will merge it soon and ask you to rebase you PR and only pick the things which are not already fixed by the previous pr. |
|
Can you rebase as we've merged some changes into In general the PR looks good, but we need to check if we can include the contracts related to your oracle service, for business reasons. |
|
yup will do soon - will have the contract features in separate commits. |
|
Closing this gig as it is superseeded by PR#24 |
Hey team,
I've made a few minor improvements to make our local development setup smoother and more robust for transmitter users
The Problem
When I first set up the project, I ran into a few small snags:
dotenvpackage was missing from our dependencies..envfile.The Fix
dotenvpackage to ourpackage.json.docker-compose.ymlso the Redis container starts up happily even if a password isn't set + minor edits like depends_on to make sure redis is runningYou can test by following the steps in the original PR description. All my local checks have passed!
Thanks!