Skip to content
This repository was archived by the owner on Mar 7, 2025. It is now read-only.

👕 Refactor blueprints#162

Merged
abhisuri97 merged 7 commits intohack4impact:masterfrom
anselal:refactor_admin_blueprint
Apr 27, 2018
Merged

👕 Refactor blueprints#162
abhisuri97 merged 7 commits intohack4impact:masterfrom
anselal:refactor_admin_blueprint

Conversation

@anselal
Copy link
Contributor

@anselal anselal commented Apr 23, 2018

Refactor imports and apply some PEP8

@anselal
Copy link
Contributor Author

anselal commented Apr 23, 2018

The error makes no sense

@anselal anselal changed the title 👕 Refactor admin blueprint 👕 Refactor blueprints Apr 23, 2018
@abhisuri97
Copy link
Contributor

Closing in favor of other one #161

@abhisuri97 abhisuri97 closed this Apr 23, 2018
@anselal
Copy link
Contributor Author

anselal commented Apr 23, 2018

Actually this one should be open and #161 should close.
This one includes the changes from #161.
Sorry for that.

@abhisuri97 abhisuri97 reopened this Apr 23, 2018
@anselal
Copy link
Contributor Author

anselal commented Apr 23, 2018

I will push more changes here

@anselal
Copy link
Contributor Author

anselal commented Apr 23, 2018

I am done refactoring for now !
You can check if this PR suits you

@abhisuri97 abhisuri97 merged commit 37c27fc into hack4impact:master Apr 27, 2018
@abhisuri97
Copy link
Contributor

merged

@anselal
Copy link
Contributor Author

anselal commented Apr 27, 2018

Great, thank you !!

@anselal
Copy link
Contributor Author

anselal commented Apr 27, 2018

I see here https://circleci.com/gh/hack4impact/flask-base/307 that there is an import error I cannot replicate.

@anselal
Copy link
Contributor Author

anselal commented Apr 27, 2018

I fixed this at #166

abhisuri97 added a commit that referenced this pull request May 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants