-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added floating UI and animation #27
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Lindsay-X
commented
Jun 18, 2024
•
edited
Loading
edited
- 2 boats in hero
- a shark in sponsor
- a turtle in testimony
- 2 fishes in FAQ
- Bubble movements in why us
- slightly altered Animate to include repeat features
- 2 boats in hero - a shark in sponsor - a turtle in testimony - 2 fishes in FAQ
Deploying 2024-hackthe6ix-com with Cloudflare Pages
|
Added bubble moment for fun (idk if we want it)
fpunny
reviewed
Jun 22, 2024
fpunny
reviewed
Jun 23, 2024
at a first glance, the animations are really cute and i really liked the attention to detail with some of the bobbing of the fishes. very great work :D |
fpunny
approved these changes
Jun 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thank you so much for the changes
ivanklchung
pushed a commit
that referenced
this pull request
Jul 1, 2024
* Added floating UI and animation - 2 boats in hero - a shark in sponsor - a turtle in testimony - 2 fishes in FAQ * Bubble Fisics!!!!! Added bubble moment for fun (idk if we want it) * Bubble fisics and fish responsiveness * Linted WishWaddle?? * Changed back package-lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.