Feature: use .tool-versions #608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThisIsMissEm
force-pushed
the
feat/use-tool-versions
branch
from
0b78688 to
e982043
Compare
ThisIsMissEm
force-pushed
the
feat/use-tool-versions
branch
from
cdb762c to
0f3b1fe
Compare
webframp
reviewed
Jan 27, 2025
There was a problem hiding this comment.
Non blocking, but a question: Is .tool-version an asdf thing or from somewhere else? I like the idea just haven't seen it that generic before and am curious
Contributor
Author
There was a problem hiding this comment.
It's kinda an asdf thing, though a few other tools are also interoperable with it: https://asdf-vm.com/manage/configuration.html#tool-versions
e-nomem
approved these changes
Jan 30, 2025
Contributor
e-nomem
left a comment
e-nomem
left a comment
There was a problem hiding this comment.
I don't regularly use asdf, but LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pretty basic, but it'll help when contributing to both community.hachyderm.io and nivenly.org, as they use different hugo versions, so installing them through a version manager such as
asdfsimplifies things.Rather than repeating the version twice, I parse the .tool-versions file for the hugo version, assuming we always use extended mode.